Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43648

Course start date changes for itself depending on the editor user's timezone.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Manual testing:

      This requires 2 courses (TC1 and TC2), and 2 editing teachers in each:

      • editor1 - your time zone
      • editor2 - another time zone

      Restore test:

      1. Set the start date of TC1 to today at noon.
      2. Back up TC1
      3. Restore the backup from TC1 into TC2 (Merging the settings)
      4. As part of the restore process override the start date to tomorrow at 6AM
      5. Finish the restore and verify that the start date is correct.

      Course reset test:

      1. Run the course reset on course TC1 and change the start and end dates to tomorrow at 9AM
      2. Verify that the end dates were changed to the new date / time

      Course editing test: (This requires 2 teachers each with different time zones set in their profile)

      1. As Teacher #1 edit TC1 and set the course start date to today at noon.
      2. In a separate browser, log in as Teacher #2 and edit the course description for course TC1. (make note of the course start time)
      3. As Teacher #1 edit TC1 and verify that the course start time is still set to noon (your local time)
      4. As Teacher #2 re-edit the course TC1, verify that the course start time has not changed.
      5. Use a tool like (https://www.timeanddate.com/) and verify that the course start time noted above is noon of the current day for the time zone of Teacher #1
      Show
      Manual testing: This requires 2 courses (TC1 and TC2), and 2 editing teachers in each: editor1 - your time zone editor2 - another time zone Restore test: Set the start date of TC1 to today at noon. Back up TC1 Restore the backup from TC1 into TC2 (Merging the settings) As part of the restore process override the start date to tomorrow at 6AM Finish the restore and verify that the start date is correct. Course reset test: Run the course reset on course TC1 and change the start and end dates to tomorrow at 9AM Verify that the end dates were changed to the new date / time Course editing test: (This requires 2 teachers each with different time zones set in their profile) As Teacher #1 edit TC1 and set the course start date to today at noon. In a separate browser, log in as Teacher #2 and edit the course description for course TC1. (make note of the course start time) As Teacher #1 edit TC1 and verify that the course start time is still set to noon (your local time) As Teacher #2 re-edit the course TC1, verify that the course start time has not changed. Use a tool like ( https://www.timeanddate.com/) and verify that the course start time noted above is noon of the current day for the time zone of Teacher #1
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_33_STABLE
    • Fixed Branches:
      MOODLE_35_STABLE
    • Pull Master Branch:
      MDL-43648_m35v2

      Description

      The course start under Moodle is defined only by date. There is no option for the user to set the desired time for that.

      FULL STEPS:
      As Administrator, create another admnistrator user having a different timezone. The first one set his profile's timezone to UTC-3. The second one set the timezone to UTC-5.
      As the first Administrator, create a new course set to start January the 1st, 2014. Save it. The timestamp saved is 1388545200 (regarding my server settings).
      As the second Administrator edit that course do nothing there. Save it then. (Once I openned it, it showed December 31st, 2013). Now the timestamp saved is 1388466000.
      It can go over and over again, losing one day each time this sequence is done.

      WHAT I EXPECTED
      I understand that the time difference regarding the timezones (2 hours in this case), may affect the day referenced there. The main purpose on that is because the time API defaults the time to 00:00 in the referenced date. As I open it 2 hours before it makes sence to show the date one day earlier. Once I reopen the course for editing with the original creator, it was expected that the course would start at the same date he created it (Jan the 1st, 2014), as nothing was edited anywhere. But the start date was actually Dec 31st, 2013.

      I believe that discarding the hours, minutes and seconds for the date field once it is edited is a mistake, and could lead to problems like that that could cause the dates to change over and over without any reason. Once I set conditional access N days after course start, it could bring even some other problems.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sbourget Stephen Bourget
              Reporter:
              luis.alcantara Luis Gustavo Mueller de Alcantara
              Peer reviewer:
              Ryan Wyllie
              Integrator:
              Andrew Nicols
              Tester:
              Janelle Barcega
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              Votes:
              4 Vote for this issue
              Watchers:
              12 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/May/18