Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Blocker
-
Resolution: Fixed
-
Affects Version/s: 2.6
-
Fix Version/s: 2.6.2
-
Component/s: Automated functional tests (behat), JavaScript
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_26_STABLE
-
Fixed Branches:MOODLE_26_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-43664-master -
Pull Master Diff URL:
-
Story Points:5
-
Sprint:FRONTEND Sprint 8
Description
The M.util.js_complete tests introduced by MDL-41030 use Array.indexOf.
Unfortunately IE8 and below do not support indexOf.
Although we don't support IE8, we shouldn't break this badly.
Possible solutions include:
- return early if indexOf does not exit on the Array;
- switch to YUI's Array functions; and
- monkey patch indexOf onto the Array.
Since we don't support IE8, nor do we test it, I think we should just exit if the indexOf function doesn't exist.