Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43664

JavaScript breaks on IE <= 8

    XMLWordPrintable

    Details

    • Story Points:
      5
    • Sprint:
      FRONTEND Sprint 8

      Description

      The M.util.js_complete tests introduced by MDL-41030 use Array.indexOf.
      Unfortunately IE8 and below do not support indexOf.

      Although we don't support IE8, we shouldn't break this badly.

      Possible solutions include:

      1. return early if indexOf does not exit on the Array;
      2. switch to YUI's Array functions; and
      3. monkey patch indexOf onto the Array.

      Since we don't support IE8, nor do we test it, I think we should just exit if the indexOf function doesn't exist.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Frédéric Massart
              Integrator:
              Dan Poltawski
              Tester:
              Jason Fowler
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Mar/14