Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43693

assignment: js error on grading page if no users listed.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.4, 2.6.1
    • Fix Version/s: 2.5.5, 2.6.2
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      On 2.5/2.6:

      1. Create course with no enrolled users;
      2. Create assignment in the created course;
      3. Open grading page of assignment (as site admin);
      4. Open dev console, try to modify any filtering option and make sure the page is reloaded and no errors reported.

      On master:

      1. Create course with one enrolled user;
      2. Create assignment in the created course;
      3. Open grading page of assignment (as site admin);
      4. Open dev console, try to modify any filtering option and make sure the page is reloaded and no errors reported.
      5. Open course enrolment page and set enrolment expire day for only one user to the date in the past (make enrolment expire).
      6. Open grading page for assignment and toggle "Show only active enrolments" few times - page should reload on each checkbox click, no errors should be in the console.
      Show
      On 2.5/2.6: Create course with no enrolled users; Create assignment in the created course; Open grading page of assignment (as site admin); Open dev console, try to modify any filtering option and make sure the page is reloaded and no errors reported. On master: Create course with one enrolled user; Create assignment in the created course; Open grading page of assignment (as site admin); Open dev console, try to modify any filtering option and make sure the page is reloaded and no errors reported. Open course enrolment page and set enrolment expire day for only one user to the date in the past (make enrolment expire). Open grading page for assignment and toggle "Show only active enrolments" few times - page should reload on each checkbox click, no errors should be in the console.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43693-master
    • Pull Master Diff URL:

      Description

      If the list of enrolled users on assignment grading page is empty (because no users are enrolled or, more likely, the filtering condition results in no users listed), the JS error will occur, that will stop the rest to JS script from execution.

        Attachments

          Issue Links

          duplicates

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43486 JavaScript error in mod_assign when no enrolments exist in course

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              kabalin Ruslan Kabalin
              Reporter:
              kabalin Ruslan Kabalin
              Peer reviewer:
              Damyon Wiese
              Integrator:
              Dan Poltawski
              Tester:
              Jason Fowler
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Mar/14