Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43725

Undefined variable $strlogs in Live logs

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.8
    • Fix Version/s: 2.5.5, 2.6.2
    • Component/s: Reports
    • Labels:
    • Story Points (Obsolete):
      3
    • Sprint:
      BACKEND Sprint 9

      Description

      I get a notice:
      Notice: Undefined variable: strlogs in /home/jakubka/workspace/moodle/report/loglive/index.php on line 81

      $strlivelogs is used all over the file so maybe that should be on that line instead

      The address is in form of:
      /report/loglive/index.php?id=XXX

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            ankit_frenz Ankit Agarwal added a comment - - edited

            Came across this while working on MDL-43682, attaching a fix, this should now match report/log. Please note this would re written as part of MDL-43682, so it is fine not to integrate this in master.

            Show
            ankit_frenz Ankit Agarwal added a comment - - edited Came across this while working on MDL-43682 , attaching a fix, this should now match report/log. Please note this would re written as part of MDL-43682 , so it is fine not to integrate this in master.
            Hide
            skodak Petr Skoda added a comment -

            +1

            Show
            skodak Petr Skoda added a comment - +1
            Hide
            damyon Damyon Wiese added a comment -

            Thanks Fred, looks good. Integrated to 25, 26 and master.

            Show
            damyon Damyon Wiese added a comment - Thanks Fred, looks good. Integrated to 25, 26 and master.
            Hide
            damyon Damyon Wiese added a comment -

            Sorry - Fred gets no thanks. Thanks Ankit!

            Show
            damyon Damyon Wiese added a comment - Sorry - Fred gets no thanks. Thanks Ankit!
            Hide
            fred Frédéric Massart added a comment -

            Passing.

            Show
            fred Frédéric Massart added a comment - Passing.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            I won't be saying "Thanks!" this week. I'm tired of it.

            For the good (and the bad), your code is now part of Moodle, the best LMS in the world. Hope you are contributing for that to continue being a fact (and not the opposite), sincerely.

            Just closing this as fixed, ciao

            PS: Just a bit of black/cruel humor, sorry, LOL!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - I won't be saying "Thanks!" this week. I'm tired of it. For the good (and the bad), your code is now part of Moodle, the best LMS in the world. Hope you are contributing for that to continue being a fact (and not the opposite), sincerely. Just closing this as fixed, ciao PS: Just a bit of black/cruel humor, sorry, LOL!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Mar/14