Moodle
  1. Moodle
  2. MDL-43725

Undefined variable $strlogs in Live logs

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.8
    • Fix Version/s: 2.5.5, 2.6.2
    • Component/s: Reports
    • Labels:
    • Story Points (Obsolete):
      3
    • Sprint:
      BACKEND Sprint 9

      Description

      I get a notice:
      Notice: Undefined variable: strlogs in /home/jakubka/workspace/moodle/report/loglive/index.php on line 81

      $strlivelogs is used all over the file so maybe that should be on that line instead

      The address is in form of:
      /report/loglive/index.php?id=XXX

        Gliffy Diagrams

          Activity

          Hide
          Ankit Agarwal added a comment - - edited

          Came across this while working on MDL-43682, attaching a fix, this should now match report/log. Please note this would re written as part of MDL-43682, so it is fine not to integrate this in master.

          Show
          Ankit Agarwal added a comment - - edited Came across this while working on MDL-43682 , attaching a fix, this should now match report/log. Please note this would re written as part of MDL-43682 , so it is fine not to integrate this in master.
          Hide
          Petr Skoda added a comment -

          +1

          Show
          Petr Skoda added a comment - +1
          Hide
          Damyon Wiese added a comment -

          Thanks Fred, looks good. Integrated to 25, 26 and master.

          Show
          Damyon Wiese added a comment - Thanks Fred, looks good. Integrated to 25, 26 and master.
          Hide
          Damyon Wiese added a comment -

          Sorry - Fred gets no thanks. Thanks Ankit!

          Show
          Damyon Wiese added a comment - Sorry - Fred gets no thanks. Thanks Ankit!
          Hide
          Frédéric Massart added a comment -

          Passing.

          Show
          Frédéric Massart added a comment - Passing.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I won't be saying "Thanks!" this week. I'm tired of it.

          For the good (and the bad), your code is now part of Moodle, the best LMS in the world. Hope you are contributing for that to continue being a fact (and not the opposite), sincerely.

          Just closing this as fixed, ciao

          PS: Just a bit of black/cruel humor, sorry, LOL!

          Show
          Eloy Lafuente (stronk7) added a comment - I won't be saying "Thanks!" this week. I'm tired of it. For the good (and the bad), your code is now part of Moodle, the best LMS in the world. Hope you are contributing for that to continue being a fact (and not the opposite), sincerely. Just closing this as fixed, ciao PS: Just a bit of black/cruel humor, sorry, LOL!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile