Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43740

Setting the "Grade type" of a manual grade item to "None" removes it from the Gradebook UI

    Details

    • Testing Instructions:
      Hide

      Create a manual grade item. Check that you cannot set grade type to "None".

      Check that all behat and unit tests passed.

      Show
      Create a manual grade item. Check that you cannot set grade type to "None". Check that all behat and unit tests passed.
    • Workaround:
      Hide

      There are two methods available, both of them require editing the database directly:

      Firstly, go to the database and look in the grade_items table. Look for a manual grade item that has ## tokens in it, but which is not visible in the Gradebook GUI.

      Then either:

      1. Delete the record. Problem solved.

      2. Edit the record, changing the value of gradetype from 0 to 1 (this corresponds to changing the setting "Grade type" from "None" to "Value" in the Gradebook UI). The grade item now reappears in the Gradebook UI. Go to the Gradebook UI and either edit the grade item to remove the ##token, or delete it. Problem solved.

      Show
      There are two methods available, both of them require editing the database directly: Firstly, go to the database and look in the grade_items table. Look for a manual grade item that has ## tokens in it, but which is not visible in the Gradebook GUI. Then either: 1. Delete the record. Problem solved. 2. Edit the record, changing the value of gradetype from 0 to 1 (this corresponds to changing the setting "Grade type" from "None" to "Value" in the Gradebook UI). The grade item now reappears in the Gradebook UI. Go to the Gradebook UI and either edit the grade item to remove the ##token, or delete it. Problem solved.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Epic Link:
    • Pull 2.7 Branch:
      MDL-43740_manual_none_27
    • Pull Master Branch:
      MDL-43740_manual_none
    • Story Points (Obsolete):
      13
    • Sprint:
      BACKEND Sprint 15

      Description

      Symptoms (all related to the Gradebook):

      1. The Course Total column indicates "Error" for all students. (see screenshot 1)
      2. The User Report gives the following error message: "An error occurred during grade calculation: Probably circular reference or broken calculation formula." (see screenshot 2)
      3. The export to Excel spreadsheet function gives the following error message: "An error occurred during grade calculation: Probably circular reference or broken calculation formula." (see screenshot 3)
      4. There are no broken formulas in the Gradebook UI, meaning that there is no way to fix this error.

      Steps to reproduce:

      1. Create a manual grade item in the Gradebook.
      2. Enter a formula in the grade item, referring to another grade item, such as =SUM([[X]],[[Y]]).
      3. Then delete one of the grade items that are referred to in the aforementioned formula, e.g. delete the grade item referred to as "X".
      4. Examine the formula; it should now have a ## token indicating that it is pointing to a non-existent grade item.
      5. Edit the grade item and change the value of "Grade type" from "Value" to "None"
      6. Examine the Gradebook - THE ITEM HAS NOW DISAPPEARED FROM THE GRADEBOOK GUI.
      7. Examine the database (if possible) - the manual grade item still exists with gradetype=0 and the gradebook error persists. It is now only possible to solve this problem directly in the database.

      Cause:

      I have updated this report after our IT Support were able to track down the source of the problem.

      This problem is caused by the behaviour under item 6 in "Steps to Reproduce" above; namely, SETTING THE "GRADE TYPE" OF A MANUAL GRADE ITEM TO "NONE" REMOVES IT FROM THE GRADEBOOK GUI.

      This has happened on two separate courses which caused us major problems and it has taken us 6 months to track it down.

        Gliffy Diagrams

          Attachments

          1. 1.PNG
            1.PNG
            8 kB
          2. 2.PNG
            2.PNG
            12 kB
          3. 3.PNG
            3.PNG
            10 kB

            Issue Links

              Activity

                People

                • Votes:
                  4 Vote for this issue
                  Watchers:
                  9 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    8/Sep/14