Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43765

Additional name fields notice when viewing Course participation report

    Details

    • Sprint:
      BACKEND Sprint 9

      Description

      While viewing Course participation report, additional name fields notice appear.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Setting Adrian as peer reviewer.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Setting Adrian as peer reviewer.
            Hide
            cibot CiBoT added a comment -
            Show
            cibot CiBoT added a comment - Results for MDL-43765 Remote repository: https://github.com/rajeshtaneja/moodle.git Remote branch wip-mdl-43765-m26 to be integrated into upstream MOODLE_26_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/666 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/666/artifact/work/smurf.html Remote branch wip-mdl-43765 to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/667 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/667/artifact/work/smurf.html
            Hide
            abgreeve Adrian Greeve added a comment -

            Thanks Raj for fixing this issue.

            I do have one single question -
            Is the reason that you remove u.idnumber from the sql statement because it doesn't seem to be used at all?
            No problems found.
            Feel free to send to integration.

            Show
            abgreeve Adrian Greeve added a comment - Thanks Raj for fixing this issue. I do have one single question - Is the reason that you remove u.idnumber from the sql statement because it doesn't seem to be used at all? No problems found. Feel free to send to integration.
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks for looking at this Adrian,

            Pushing it for integration.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks for looking at this Adrian, Pushing it for integration.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            cibot CiBoT added a comment -

            Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

            Show
            cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated (26 & master), thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (26 & master), thanks!
            Hide
            dmonllao David Monllaó added a comment -

            It passes. Tested in 26 and master.

            Show
            dmonllao David Monllaó added a comment - It passes. Tested in 26 and master.
            Hide
            marina Marina Glancy added a comment -

            Thanks for your hard work. Your code has now become a part of Moodle!

            Show
            marina Marina Glancy added a comment - Thanks for your hard work. Your code has now become a part of Moodle!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Mar/14

                  Agile