Moodle
  1. Moodle
  2. MDL-43766

Loglive report has uninitialised variable

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.11, 2.4.8, 2.5.4, 2.6.1, 2.7
    • Fix Version/s: 2.5.5, 2.6.2
    • Component/s: Reports
    • Labels:

      Description

      $strlogs is not initialised in loglive/index.php and throw error.

        Gliffy Diagrams

          Activity

          Hide
          CiBoT added a comment -
          Show
          CiBoT added a comment - Results for MDL-43766 Remote repository: https://github.com/rajeshtaneja/moodle.git Remote branch wip-mdl-43766-m25 to be integrated into upstream MOODLE_25_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/668 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/668/artifact/work/smurf.html Remote branch wip-mdl-43766-m26 to be integrated into upstream MOODLE_26_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/669 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/669/artifact/work/smurf.html Remote branch wip-mdl-43766 to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/670 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/670/artifact/work/smurf.html
          Hide
          Rossiani Wijaya added a comment -

          Hi Raj,

          The patch looks great.

          As for the testing instructions, you might want to add '&inpop=0' param to the url in order to test this properly.

          [y] Syntax
          [y] Whitespace
          [y] Output
          [-] Language
          [-] Databases
          [y] Testing (instructions and automated tests)
          [-] Security
          [-] Documentation
          [y] Git
          [-] Third party code
          [y] Sanity check

          Please feel free to submit it for integration review.

          Show
          Rossiani Wijaya added a comment - Hi Raj, The patch looks great. As for the testing instructions, you might want to add '&inpop=0' param to the url in order to test this properly. [y] Syntax [y] Whitespace [y] Output [-] Language [-] Databases [y] Testing (instructions and automated tests) [-] Security [-] Documentation [y] Git [-] Third party code [y] Sanity check Please feel free to submit it for integration review.
          Hide
          Rajesh Taneja added a comment -

          Thanks Rossie,

          Added &inpop=0 to testing instructions. Pushing it for integration.

          Show
          Rajesh Taneja added a comment - Thanks Rossie, Added &inpop=0 to testing instructions. Pushing it for integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          CiBoT added a comment -

          Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

          Show
          CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (25, 26 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (25, 26 & master), thanks!
          Hide
          David Monllaó added a comment -

          It passes. Tested in 25, 25 and master.

          Show
          David Monllaó added a comment - It passes. Tested in 25, 25 and master.
          Hide
          Marina Glancy added a comment -

          Thanks for your hard work. Your code has now become a part of Moodle!

          Show
          Marina Glancy added a comment - Thanks for your hard work. Your code has now become a part of Moodle!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: