Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43773

Name column headings in Choice text file export reversed

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.8, 2.5.4, 2.6.1, 2.7
    • Fix Version/s: 2.5.5, 2.6.2
    • Component/s: Choice
    • Labels:
    • Testing Instructions:
      Hide

      Prerequisites:

      • A course containing a Choice activity with at least one response

      Test:

      • Go to the Choice report page as a teacher
      • Download the report in text format
      • Open the downloaded text report
      • Check that the name column headings match the data, with lastname as the first column
      Show
      Prerequisites: A course containing a Choice activity with at least one response Test: Go to the Choice report page as a teacher Download the report in text format Open the downloaded text report Check that the name column headings match the data, with lastname as the first column
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43773-master

      Description

      The firstname and lastname column headings in the text file export for the Choice activity are the wrong way around, and don't match the data. Lastname should come first, as in the other two export formats.

        Gliffy Diagrams

          Activity

          Hide
          cibot CiBoT added a comment -
          Show
          cibot CiBoT added a comment - Results for MDL-43773 Remote repository: https://github.com/lucisgit/moodle Remote branch MDL-43773 -master to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/672 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/672/artifact/work/smurf.html
          Hide
          danmarsden Dan Marsden added a comment -

          looks ok to me - feel free to submit to integration when ready... I wonder how long that has been a problem!

          Show
          danmarsden Dan Marsden added a comment - looks ok to me - feel free to submit to integration when ready... I wonder how long that has been a problem!
          Hide
          salvetore Michael de Raadt added a comment -

          Thanks for working on this, Tony. Please continue.

          It would be good if your fix could be backported to older supported branches also.

          Show
          salvetore Michael de Raadt added a comment - Thanks for working on this, Tony. Please continue. It would be good if your fix could be backported to older supported branches also.
          Hide
          tonybutler Tony Butler added a comment -

          Thanks Michael. I've added branches for 2.4, 2.5 and 2.6.

          Show
          tonybutler Tony Butler added a comment - Thanks Michael. I've added branches for 2.4, 2.5 and 2.6.
          Hide
          tonybutler Tony Butler added a comment -

          Thanks Dan, but I can't find an option to submit for integration. Is this something I can do?

          Show
          tonybutler Tony Butler added a comment - Thanks Dan, but I can't find an option to submit for integration. Is this something I can do?
          Show
          cibot CiBoT added a comment - Results for MDL-43773 Remote repository: https://github.com/lucisgit/moodle Remote branch MDL-43773 -MOODLE_24_STABLE to be integrated into upstream MOODLE_24_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/690 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/690/artifact/work/smurf.html Remote branch MDL-43773 -MOODLE_25_STABLE to be integrated into upstream MOODLE_25_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/691 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/691/artifact/work/smurf.html Remote branch MDL-43773 -MOODLE_26_STABLE to be integrated into upstream MOODLE_26_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/692 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/692/artifact/work/smurf.html Remote branch MDL-43773 -master to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/693 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/693/artifact/work/smurf.html
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          cibot CiBoT added a comment -

          Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

          Show
          cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          hehe, nice (since ever) one. While I'm going to integrate this, really we should move the report to provide the information adjusted to user/site preferences and configuration (instead of current harcoded last+first). Please consider creating another issue for that.

          Proceeding with this...

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - hehe, nice (since ever) one. While I'm going to integrate this, really we should move the report to provide the information adjusted to user/site preferences and configuration (instead of current harcoded last+first). Please consider creating another issue for that. Proceeding with this...
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Integrated (25, 26 & master), thanks!

          Note 24_STABLE is out of support and only security fixes land there.

          Ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Integrated (25, 26 & master), thanks! Note 24_STABLE is out of support and only security fixes land there. Ciao
          Hide
          andyjdavis Andrew Davis added a comment -

          Works as described. Passing.

          Show
          andyjdavis Andrew Davis added a comment - Works as described. Passing.
          Hide
          marina Marina Glancy added a comment -

          Thanks for your hard work. Your code has now become a part of Moodle!

          Show
          marina Marina Glancy added a comment - Thanks for your hard work. Your code has now become a part of Moodle!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Mar/14