Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43784

Clean up all the themes shipping in 2.7 by removing some from core

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      In the latest weekly

      Use a DIFFERENT theme from that list for each the following steps: afterburner, anomaly, arialist, binarius, boxxie, brick, formal_white, formfactor, fusion, leatherbound, magazine, nimble, nonzero, overlay, serenity, sky_high, splash, standard and standardold

      1. Using the theme selector, select a theme for
        • Default
        • Legacy
        • Tablet
        • Mobile
      2. Set a preferred theme for any user
      3. Force a theme in a category
      4. Force a theme in a course
      5. Force a theme for a MNet peer (Home ► Site administration ► Networking ► Peers)
      6. Configure some settings in a few themes (still in the list above) - Remember one of them (I'll call it theme_x)

      Checkout the latest integration, DO NOT UPGRADE yet

      1. Now that theme_x has disappeared from the themes directory, copy it back in.

      Upgrade now

      1. Run the upgrade
        • Make sure theme_x is not mentioned in the list of themes to be upgraded or deleted
        • Make sure the theme used during upgrade is Clean and not the one you set above
      2. Make sure the value has been set to clean (except if it was theme_x) in
        • The user's preferred theme
        • The forced theme for the course
        • The forced theme for the category
        • The forced theme for the MNet peer
      3. Make sure the theme selectors is not using any of the themes you had set previously (except for theme_x)
      4. Check the table mdl_config_plugins and make sure you do not find any entries for any of the themes listed above, except for theme_x.

      Install

      • Run a fresh install on the latest integration, make sure it works fine.

      Unit Tests

      • Run all the tests
      Show
      In the latest weekly Use a DIFFERENT theme from that list for each the following steps: afterburner, anomaly, arialist, binarius, boxxie, brick, formal_white, formfactor, fusion, leatherbound, magazine, nimble, nonzero, overlay, serenity, sky_high, splash, standard and standardold Using the theme selector, select a theme for Default Legacy Tablet Mobile Set a preferred theme for any user Force a theme in a category Force a theme in a course Force a theme for a MNet peer (Home ► Site administration ► Networking ► Peers) Configure some settings in a few themes (still in the list above) - Remember one of them (I'll call it theme_x) Checkout the latest integration, DO NOT UPGRADE yet Now that theme_x has disappeared from the themes directory, copy it back in. Upgrade now Run the upgrade Make sure theme_x is not mentioned in the list of themes to be upgraded or deleted Make sure the theme used during upgrade is Clean and not the one you set above Make sure the value has been set to clean (except if it was theme_x) in The user's preferred theme The forced theme for the course The forced theme for the category The forced theme for the MNet peer Make sure the theme selectors is not using any of the themes you had set previously (except for theme_x) Check the table mdl_config_plugins and make sure you do not find any entries for any of the themes listed above, except for theme_x. Install Run a fresh install on the latest integration, make sure it works fine. Unit Tests Run all the tests
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43784-master
    • Story Points (Obsolete):
      20
    • Sprint:
      FRONTEND Sprint 11

      Description

      Moodle 2.7 contains two "base" themes that developers are maintaining:

      • base: the old deprecated base theme with minimal CSS to be functional.
      • bootstrapbase: the new responsive base theme with minimal CSS to be functional.

      As well as this theme that a lot of community themes use as a parent theme:

      • canvas: created by New School Learning but no longer maintained much

      None of the above themes are selectable for use as themes themselves.

      Moodle 2.7 will have two selectable themes based on bootstrapbase:

      • clean: as default, implementing almost pure bootstrapbase and to provide an clonable example of a basic theme
      • more: to allow basic admins to make simple tweaks to colours, images and CSS from UI without needing to touch files.

      Everything else should be removed and put into github.com as public projects (if anyone wants to maintain them) and moodle.org/plugins for download:

      • afterburner
      • anomaly
      • arialist
      • binarius
      • boxxie
      • brick
      • formal_white
      • formfactor
      • fusion
      • leatherbound
      • magazine
      • nimble
      • nonzero
      • overlay
      • serenity
      • sky_high
      • splash
      • standard
      • standardold

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  2 Vote for this issue
                  Watchers:
                  17 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/May/14