Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43784

Clean up all the themes shipping in 2.7 by removing some from core

    XMLWordPrintable

Details

    • New Feature
    • Resolution: Fixed
    • Blocker
    • 2.7
    • 2.7
    • Themes
    • MOODLE_27_STABLE
    • MOODLE_27_STABLE
    • MDL-43784-master
    • Hide

      In the latest weekly

      Use a DIFFERENT theme from that list for each the following steps: afterburner, anomaly, arialist, binarius, boxxie, brick, formal_white, formfactor, fusion, leatherbound, magazine, nimble, nonzero, overlay, serenity, sky_high, splash, standard and standardold

      1. Using the theme selector, select a theme for
        • Default
        • Legacy
        • Tablet
        • Mobile
      2. Set a preferred theme for any user
      3. Force a theme in a category
      4. Force a theme in a course
      5. Force a theme for a MNet peer (Home ► Site administration ► Networking ► Peers)
      6. Configure some settings in a few themes (still in the list above) - Remember one of them (I'll call it theme_x)

      Checkout the latest integration, DO NOT UPGRADE yet

      1. Now that theme_x has disappeared from the themes directory, copy it back in.

      Upgrade now

      1. Run the upgrade
        • Make sure theme_x is not mentioned in the list of themes to be upgraded or deleted
        • Make sure the theme used during upgrade is Clean and not the one you set above
      2. Make sure the value has been set to clean (except if it was theme_x) in
        • The user's preferred theme
        • The forced theme for the course
        • The forced theme for the category
        • The forced theme for the MNet peer
      3. Make sure the theme selectors is not using any of the themes you had set previously (except for theme_x)
      4. Check the table mdl_config_plugins and make sure you do not find any entries for any of the themes listed above, except for theme_x.

      Install

      • Run a fresh install on the latest integration, make sure it works fine.

      Unit Tests

      • Run all the tests
      Show
      In the latest weekly Use a DIFFERENT theme from that list for each the following steps: afterburner, anomaly, arialist, binarius, boxxie, brick, formal_white, formfactor, fusion, leatherbound, magazine, nimble, nonzero, overlay, serenity, sky_high, splash, standard and standardold Using the theme selector, select a theme for Default Legacy Tablet Mobile Set a preferred theme for any user Force a theme in a category Force a theme in a course Force a theme for a MNet peer (Home ► Site administration ► Networking ► Peers) Configure some settings in a few themes (still in the list above) - Remember one of them (I'll call it theme_x) Checkout the latest integration, DO NOT UPGRADE yet Now that theme_x has disappeared from the themes directory, copy it back in. Upgrade now Run the upgrade Make sure theme_x is not mentioned in the list of themes to be upgraded or deleted Make sure the theme used during upgrade is Clean and not the one you set above Make sure the value has been set to clean (except if it was theme_x) in The user's preferred theme The forced theme for the course The forced theme for the category The forced theme for the MNet peer Make sure the theme selectors is not using any of the themes you had set previously (except for theme_x) Check the table mdl_config_plugins and make sure you do not find any entries for any of the themes listed above, except for theme_x. Install Run a fresh install on the latest integration, make sure it works fine. Unit Tests Run all the tests
    • 20
    • FRONTEND Sprint 11

    Description

      Moodle 2.7 contains two "base" themes that developers are maintaining:

      • base: the old deprecated base theme with minimal CSS to be functional.
      • bootstrapbase: the new responsive base theme with minimal CSS to be functional.

      As well as this theme that a lot of community themes use as a parent theme:

      • canvas: created by New School Learning but no longer maintained much

      None of the above themes are selectable for use as themes themselves.

      Moodle 2.7 will have two selectable themes based on bootstrapbase:

      • clean: as default, implementing almost pure bootstrapbase and to provide an clonable example of a basic theme
      • more: to allow basic admins to make simple tweaks to colours, images and CSS from UI without needing to touch files.

      Everything else should be removed and put into github.com as public projects (if anyone wants to maintain them) and moodle.org/plugins for download:

      • afterburner
      • anomaly
      • arialist
      • binarius
      • boxxie
      • brick
      • formal_white
      • formfactor
      • fusion
      • leatherbound
      • magazine
      • nimble
      • nonzero
      • overlay
      • serenity
      • sky_high
      • splash
      • standard
      • standardold

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-41551 Block drag/drop broken for clean theme on /my

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-44967 Upgrade fails if the site has already removed all core thems

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-46472 Upgrade to 2.7 stuck in 'upgrade database now' loop with undeletable themes

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDLSITE-3246 theme_formalwhite is missing from the plugins db

          • High - Customer/Partner Issue, GDPR removal, priority Features
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-59175 Inherited permissions not highlighted on the override permissions page

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-44705 Upload the retired themes on Moodle.org

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          is blocked by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-44364 Add new settings in More that use LESS

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-44357 Compile LESS from PHP

          • Minor - Minor loss of function where workaround is possible
          • Closed

          New Feature - A new Moodle feature which has yet to be developed. MDL-43786 "More" - a new theme like Clean but with more customisation settings in the UI

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-43839 Make Clean as the default theme in 2.7.

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Improvement - An enhancement to an existing Moodle feature. MDL-44792 Allow theme fixtures in Unit Tests

          • Minor - Minor loss of function where workaround is possible
          • Open

          Activity

            People

              fred Frédéric Massart
              jerome Jérôme Mouneyrac
              Damyon Wiese Damyon Wiese
              Sam Hemelryk Sam Hemelryk
              Adrian Greeve Adrian Greeve
              Votes:
              2 Vote for this issue
              Watchers:
              17 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/May/14