[MDL-43804] Remove tr class r0, r1 specific css from themes - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_27_STABLE
Fixed Branches:
MOODLE_27_STABLE
Pull from Repository:
git://github.com/ankitagarwal/moodle.git
Pull Master Branch:
~~MDL-43804~~-master
Pull Master Diff URL:
https://github.com/ankitagarwal/moodle/compare/183515d...MDL-43804-master
Testing Instructions:
Hide

This must be tested with all themes.

For each theme go to the following location, you should see a tabular data. Make sure it looks identical to the one without this patch. The thing to verify mostly is alternate colors for tr background.

User enrollement table

Live logs Reports for the site

Logs Reports for the site

admin/tool/customlang/index.php (open a pack for editing)

Blocks list (admin/blocks.php)

Question bank listing all questions

Create a survey with type "COLLES(ACTUAL)" and attempt it as student
Show
This must be tested with all themes. For each theme go to the following location, you should see a tabular data. Make sure it looks identical to the one without this patch. The thing to verify mostly is alternate colors for tr background. User enrollement table Live logs Reports for the site Logs Reports for the site admin/tool/customlang/index.php (open a pack for editing) Blocks list (admin/blocks.php) Question bank listing all questions Create a survey with type "COLLES(ACTUAL)" and attempt it as student

Remove r0, r1 specific css from themes.

table.flexible .r0, table.generaltable .r0 {background-color: #F0F0F0;}

table.flexible .r1, table.generaltable .r1 {background-color: #FAFAFA;}

This creates problem when adding new rows dynamically to the table.

We should use instead nth-child(even/odd).

It is supported by all browsers supported by Moodle:

blocks

MDL-43682 Rewrite loglive report to use the new logging api

has been marked as being related by

CONTRIB-4849 Update code checker to throw warnings for .r0/.r1 CSS

will help resolve

MDL-43907 Make tables of data themeable

Participants:: Andrew Lyons, Ankit Agarwal, CiBoT, Damyon Wiese, Daniel Wahl, David Scotson, Eloy Lafuente (stronk7), Gareth J Barnard, Sam Hemelryk, Tim Hunt