Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43822

Tidy up block CSS in the clean theme

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.4, 2.6.1, 2.7
    • Fix Version/s: 2.5.5, 2.6.2
    • Component/s: Blocks, Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as admin
      2. Change to the clean theme
      3. Explore the blocks, keep an eye out for styling regressions from last week.
      4. Disable JS and test moving a block (keep an eye out for the cancel move link)
      5. Change to an RTL language and ensure things are on par with last week as well.
      Show
      Log in as admin Change to the clean theme Explore the blocks, keep an eye out for styling regressions from last week. Disable JS and test moving a block (keep an eye out for the cancel move link) Change to an RTL language and ensure things are on par with last week as well.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      43822-27
    • Pull Master Diff URL:

      Description

      As clean nears becoming the default theme we need to consider tidying up the Block CSS as there are a couple of issues within it.
      The general layout could also be improved, making the most of less to clarify block structure for those who are looking to re-theme or modify.

      Issues noted:

      • `.block .header h2` and `.block .header .title h2` style the same element, conflict and one is certainly redundant.
      • `.block .blockannotation` is incorrect, the blockannotation class is not used within .block. This can be removed as its clearly not used.
      • `.block_calendar_upcoming .footer` and `.block_calendar_upcoming .content .footer` style the same element as the footer is always rendered within the content div.
      • `#searchform_search` is not specific enough, it conflicts with the styling of an element with the same ID within the tag content. It should be related to the search_forum block for which it is designed to style.
      • Padding on `.block-hider-hide` and `.block-hider-show` is unnecessary as `.block_action` padding covers these icons.

      This issue has been marked as a bug because of confusing redundancy that should be fixed in stable themes.

        Attachments

        1. 2014_02_04_12_37_20_Moodle_26.png
          2014_02_04_12_37_20_Moodle_26.png
          12 kB
        2. 2014-01-22 15_40_39-Course_ Topics.png
          2014-01-22 15_40_39-Course_ Topics.png
          29 kB
        3. 2014-02-04 12_16_51-Moodle GJB.png
          2014-02-04 12_16_51-Moodle GJB.png
          5 kB
        4. 2014-02-04 12_21_41-Moodle GJB.png
          2014-02-04 12_21_41-Moodle GJB.png
          6 kB
        5. 2014-02-04 12_28_54-Moodle GJB.png
          2014-02-04 12_28_54-Moodle GJB.png
          12 kB
        6. block1.png
          block1.png
          3 kB
        7. block2.png
          block2.png
          3 kB
        8. block3.png
          block3.png
          16 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Mar/14