Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Blocker
-
Resolution: Fixed
-
Affects Version/s: 2.7
-
Fix Version/s: 2.8
-
Component/s: Unit tests
-
Testing Instructions:
-
Affected Branches:MOODLE_27_STABLE
-
Fixed Branches:MOODLE_28_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
MDL-43440 discovered a number of places where id was used instead of cmid.
This worked as all the sequences start at the same number and unit tests only insert a limited set of modules. OUBlog broke that assumption and unit tests break. It is not in core and needs a better way to detect those kinds of coding errors.
Since the initial fix in December posted in MDL-43440, there have been another 4 test creations using the incorrect data, so the issue isn't a once of issue.
This change is to set database sequences to individual different values where possible to catch errors where we send the wrong id to a function.
Attachments
Issue Links
- caused a regression
-
MDL-47664 Oracle unit tests dramatically slowed down by 10x on 2.8.x
-
- Closed
-
-
MDL-52255 Improve performance of PHPUnit and Behat
-
- Closed
-
- has been marked as being related by
-
MDL-43926 Unit tests fail if an add-on creates a course category at install time
-
- Closed
-
-
MDL-62483 Should be harder to write fragile unit tests that make unwarranted assumptions about a new Moodle install
-
- Open
-
- is blocked by
-
MDL-43440 Wrong ids in unit tests - causes failures if an add-on a contexts on install
-
- Closed
-
- will help resolve
-
MDL-43440 Wrong ids in unit tests - causes failures if an add-on a contexts on install
-
- Closed
-