Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43838

When bootstrap window is small the login link isn't available, crippling behat tests

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test 1

      1. Wait for the CI server jobs to finish with 100% pass

      Test 2

      1. Install/update behat
      2. Ensure you don't overwrite the default theme in config.php (CFG->theme)
      3. Run @core_auth
      4. It SHOULD all pass
      5. Overwrite the default theme setting $CFG->theme = 'clean'; in config.php
      6. Run @core_auth
      7. It SHOULD all pass
      8. You should be fast now run again @core_auth but, once the browser opens, resize it to a 900px width (more or less, well, a medium size in @media terms) The thing is that we want to see the hamburger icon that should be click before showing the 'Log in' link
        • In case you think that it is impossible to have enough time to resize it you can hack auth/tests/behat/behat_auth.php and add a $this->getSession()->wait(5 * 1000, false);
      9. The link SHOULD be auto-clicked and all the @core_auth tests SHOULD pass
      Show
      Test 1 Wait for the CI server jobs to finish with 100% pass Test 2 Install/update behat Ensure you don't overwrite the default theme in config.php (CFG->theme) Run @core_auth It SHOULD all pass Overwrite the default theme setting $CFG->theme = 'clean'; in config.php Run @core_auth It SHOULD all pass You should be fast now run again @core_auth but, once the browser opens, resize it to a 900px width (more or less, well, a medium size in @media terms) The thing is that we want to see the hamburger icon that should be click before showing the 'Log in' link In case you think that it is impossible to have enough time to resize it you can hack auth/tests/behat/behat_auth.php and add a $this->getSession()->wait(5 * 1000, false); The link SHOULD be auto-clicked and all the @core_auth tests SHOULD pass
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43838_master

      Description

      Steps to reproduce (I did this in chrome)

      • Force theme to clean in config.php
      • When tests are running resize your browser window so that the login/username link in top right disappears and instead you get the 'hamburger icon' (in my environment this was only 1000px)
      • Note that next time behat tries to login or logout, behat is stuck.. it can't find the login link and the steps fail.

      Its actually not that wide a window required - I noticed this problem because my browser window opened at a size that caused all the steps to fail.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Mar/14