Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43882

Add "time spent waiting for the database" value to the performance info (backport of MDL-43758)

    XMLWordPrintable

Details

    • MOODLE_25_STABLE, MOODLE_26_STABLE
    • MOODLE_25_STABLE, MOODLE_26_STABLE
    • MDL-43882_master
    • Hide

      Test 1
      PHPunit tests should pass

      Test 2
      To test only in 2.5 and 2.6:

      1. Ensure perfdebug admin setting is disabled
      2. Ensure MDL_PERF* vars are not defined in your config.php
      3. Go to your CFG->wwwroot
      4. You SHOULD NOT see the performance info shown in the footer
      5. Set MDL_PERF vars in config.php (http://docs.moodle.org/23/en/Debugging#Performance_info)
      6. Go to your CFG->wwwroot
      7. You SHOULD see the performance info shown in the footer
      8. You SHOULD see a new var named DB queries time with a value in seconds
      Show
      Test 1 PHPunit tests should pass Test 2 To test only in 2.5 and 2.6: Ensure perfdebug admin setting is disabled Ensure MDL_PERF* vars are not defined in your config.php Go to your CFG->wwwroot You SHOULD NOT see the performance info shown in the footer Set MDL_PERF vars in config.php ( http://docs.moodle.org/23/en/Debugging#Performance_info ) Go to your CFG->wwwroot You SHOULD see the performance info shown in the footer You SHOULD see a new var named DB queries time with a value in seconds

    Description

      After we confirm that MDL-43758 is working properly and will not be risky to backport it to stables we should add pull branches for 2.5 and 2.6.

      As commented by @stronk7 this is a good opportunity to add unit tests for all those perf_get_xxx methods: (https://tracker.moodle.org/browse/MDL-43758?focusedCommentId=266521&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-266521)

      Attachments

        Activity

          People

            dmonllao David Monllaó
            dmonllao David Monllaó
            Rajesh Taneja Rajesh Taneja
            Dan Poltawski Dan Poltawski
            Sam Hemelryk Sam Hemelryk
            Matteo Scaramuccia, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              10/Mar/14