Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43896

Drop support for $module in version.php files for Moodle 3.0

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      The following scenarios should be tested:

      1. If the currently installed plugin uses the $module syntax in its version.php, debugging warning is raised at least at the Plugins overview page. That page may consider the plugin as missing from the disk. Note that this can be easily tested by changing the syntax in any of the currently installed activity modules (do not forget to purge caches after changing the version.php contents).
      2. When attempting to install a plugin using the $module syntax in version.php via the admin UI, the plugin validation must fail and the plugin is not installed.
      3. When attempting to install a plugin using the $module syntax in version.php via direct extraction of the ZIP (i.e. bypassing the validation), the installation process must fail and end with exception thrown.

      Note that you may want to test MDL-48494 as well as the procedures there will be similar.

      Thanks for your time!

      Show
      The following scenarios should be tested: If the currently installed plugin uses the $module syntax in its version.php, debugging warning is raised at least at the Plugins overview page. That page may consider the plugin as missing from the disk. Note that this can be easily tested by changing the syntax in any of the currently installed activity modules (do not forget to purge caches after changing the version.php contents). When attempting to install a plugin using the $module syntax in version.php via the admin UI, the plugin validation must fail and the plugin is not installed. When attempting to install a plugin using the $module syntax in version.php via direct extraction of the ZIP (i.e. bypassing the validation), the installation process must fail and end with exception thrown. Note that you may want to test MDL-48494 as well as the procedures there will be similar. Thanks for your time!
    • Affected Branches:
      MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43896-master-modulesyntax

      Description

      With MDL-43040, for Moodle 2.7 we moved all core modules to use $plugin->xxx in their version.php files (supported since early 2.x versions), moving away from the special $module->xxxx case. At the same time the old uses were declared deprecated (see upgrade.txt for 2.7 and also the dev docs for version.php).

      Also, it was decided that the old $module->xxxx would stop working for Moodle 3.0

      And this issue is about to clean any support in core for those old $module->xxx exceptions. To achieve it we'll need, at least:

      1) Be sure there are not remaining $module->xxxx uses in core related with version.php files.
      2) Review every MDL-43896 occurrence in core because surely it will point to some code to change/clean.

      That is all, ciao

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  16/Nov/15