Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43902

Remove r0/r1 from table tr classlist

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.9
    • Component/s: Libraries
    • Testing Instructions:
      Hide
      1. Run the following Unit Tests:
        • lib/tests/tablelib_test.php
        • lib/tests/html_writer_test.php
        • question/behaviour/deferredfeedback/tests/walkthrough_test.php
        • question/type/multichoice/tests/walkthrough_test.php
      2. Run the follow Behat tests:
        • grade/tests/behat/grade_UI_settings.feature
        • report/outline/tests/behat/outline.feature
        • question/tests/behat/copy_questions.feature
      3. Grep the code for r0 and r1
        • Make sure those are not used anywhere in styles, behat features or JS.
          • Exception made for the files listed in steps 1 and 2 (they are either fixed or hardcoded)
          • Note that hardcoded r0/r1 not generated by tablelib or html_writer are acceptable
      4. For extra points:
        1. Navigate to Home ► Site administration ► Development ► Profiling runs
          • This might require you to install xhprof and other stuff
          • Make sure the table rows have alternate background colours in base theme
        2. Create a workshop and jump to Allocate submissions
          • Make sure the table rows have alternate background colours in any theme
      Show
      Run the following Unit Tests: lib/tests/tablelib_test.php lib/tests/html_writer_test.php question/behaviour/deferredfeedback/tests/walkthrough_test.php question/type/multichoice/tests/walkthrough_test.php Run the follow Behat tests: grade/tests/behat/grade_UI_settings.feature report/outline/tests/behat/outline.feature question/tests/behat/copy_questions.feature Grep the code for r0 and r1 Make sure those are not used anywhere in styles, behat features or JS. Exception made for the files listed in steps 1 and 2 (they are either fixed or hardcoded) Note that hardcoded r0/r1 not generated by tablelib or html_writer are acceptable For extra points: Navigate to Home ► Site administration ► Development ► Profiling runs This might require you to install xhprof and other stuff Make sure the table rows have alternate background colours in base theme Create a workshop and jump to Allocate submissions Make sure the table rows have alternate background colours in any theme
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_29_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43902-master
    • Sprint:
      BACKEND Sprint 19

      Description

      Refer MDL-43804 for full discussion.

      r0/r1 classes should be removed from table generating libaries:-

      1. flexible_table::print_row
      2. html_writer::table

        Attachments

          Activity

            People

            Assignee:
            fred Frédéric Massart
            Reporter:
            ankit_frenz Ankit Agarwal
            Peer reviewer:
            Jetha Chan
            Integrator:
            Dan Poltawski
            Tester:
            John Okely
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/May/15