Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43905

incorrect code for updates of login times

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 2.6
    • 2.6.2, 2.7
    • Libraries
    • 4
    • BACKEND Sprint 10

    Description

      during event migration the code updating user login times got borked - he $USER->timemodified and db state get out of sync; it is also painfully slow...

      core_moodlelib_testcase::test_complete_user_login
      Time is lower that allowed start value
      Failed asserting that '1390980862' is equal to 1390980863 or is greater than 1390980863.
      /home/jerome/moodles/integration_master_mysqli/moodle/lib/phpunit/classes/advanced_testcase.php:393
      /home/jerome/moodles/integration_master_mysqli/moodle/lib/tests/moodlelib_test.php:2473
      /home/jerome/moodles/integration_master_mysqli/moodle/lib/phpunit/classes/advanced_testcase.php:80
      

      At the same time this code triggers extra user updated event right before user logged in event which is also not correct.

      Attachments

        Issue Links

          Activity

            People

              skodak Petr Skoda
              skodak Petr Skoda
              Rajesh Taneja Rajesh Taneja
              Marina Glancy Marina Glancy
              Rossiani Wijaya Rossiani Wijaya
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/Mar/14