Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43908

Defer submission feedback notifications for unavailable assignments

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Prerequisites:

      • A course with at least one enrolled student and one assignment activity.
      • Assignment setting 'submissionreceipts' enabled for site.

      Test:

      • Login as a student and submit to the assignment. The student should receive a submission notification (just to verify that notifications are being sent/received successfully).
      • Login as a teacher and edit the assignment settings. In the 'Restrict access' section set 'Allow access from' to a time/date in the future.
      • Give the student a grade and some feedback, making sure that 'Notify students' is set to 'No' and is frozen.
      • Verify that the student does not receive feedback notification (allow enough time for the next assignment cron, according to your cron schedule).
      • Edit the assignment settings again. In the 'Restrict access' section set 'Allow access until' to a time/date in the past.
      • Verify again that the student does not receive feedback notification.
      • Edit the assignment settings again, removing all access restrictions but hiding the assignment completely (using the visibility setting in 'Common module settings').
      • Verify again that the student does not receive feedback notification.
      • Make the assignment visible.
      • Verify that the student now receives the feedback notification.
      Show
      Prerequisites: A course with at least one enrolled student and one assignment activity. Assignment setting 'submissionreceipts' enabled for site. Test: Login as a student and submit to the assignment. The student should receive a submission notification (just to verify that notifications are being sent/received successfully). Login as a teacher and edit the assignment settings. In the 'Restrict access' section set 'Allow access from' to a time/date in the future. Give the student a grade and some feedback, making sure that 'Notify students' is set to 'No' and is frozen. Verify that the student does not receive feedback notification (allow enough time for the next assignment cron, according to your cron schedule). Edit the assignment settings again. In the 'Restrict access' section set 'Allow access until' to a time/date in the past. Verify again that the student does not receive feedback notification. Edit the assignment settings again, removing all access restrictions but hiding the assignment completely (using the visibility setting in 'Common module settings'). Verify again that the student does not receive feedback notification. Make the assignment visible. Verify that the student now receives the feedback notification.
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43908-master

      Description

      Currently the Assignment cron checks that the assignment is visible before it sends feedback notifications to students, and defers the notification until later if the assignment is hidden. However, there is currently no check for the availability of the assignment, so if the teacher has restricted access (e.g. until all grading has been completed) the students will still receive feedback notifications (containing a link to an unavailable assignment).

      Admittedly this is probably mitigated by the 'Marking workflow and allocation' functionality in Moodle 2.6, but I think this issue should still be addressed for users who aren't aware of this (or choose not to use it).

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Sep/14