Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43926

Unit tests fail if an add-on creates a course category at install time

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 2.6.1
    • 2.6.2, 2.7
    • Unit tests
    • MOODLE_26_STABLE
    • MOODLE_26_STABLE, MOODLE_27_STABLE
      1. Install mod_oublog.
      2. Run the unit tests.
    • Hide

      1. Knock up a local add-on with an install.php containing something like

      function xmldb_local_convertoldbackup_install() {
      		 
          global $DB, $CFG;
      		 
          require_once($CFG->dirroot . '/local/convertoldbackup/locallib.php');
      		 
       
      		 
          // Create category if it doesn't exist
      		 
          if (!$DB->record_exists('course_categories',
      		 
                  array('name'=>'Converted 1.9 websites'))) {
      		 
              $category = (object)array(
      		 
                  'name'=>'Converted 1.9 websites',
      		 
                  'parent'=>0,
      		 
                  'sortorder'=>90000,
      		 
                  'coursecount'=>0,
      		 
                  'visible'=>1,
      		 
                  'visibleold'=>1,
      		 
                  'depth'=>1);
      		 
              $id = $DB->insert_record('course_categories', $category);
      		 
              $DB->set_field('course_categories', 'path', '/' . $id, array('id'=>$id));
      		 
              cache::make('core', 'coursecat')->purge();
      		 
              context_coursecat::instance($id);
      		 
          }
      		 
      }

      and a version.php.

      Re-install your PHPUnit tables, and run the unit tests.

      Show
      1. Knock up a local add-on with an install.php containing something like function xmldb_local_convertoldbackup_install() { global $DB, $CFG; require_once($CFG->dirroot . '/local/convertoldbackup/locallib.php');   // Create category if it doesn't exist if (!$DB->record_exists('course_categories', array('name'=>'Converted 1.9 websites'))) { $category = (object)array( 'name'=>'Converted 1.9 websites', 'parent'=>0, 'sortorder'=>90000, 'coursecount'=>0, 'visible'=>1, 'visibleold'=>1, 'depth'=>1); $id = $DB->insert_record('course_categories', $category); $DB->set_field('course_categories', 'path', '/' . $id, array('id'=>$id)); cache::make('core', 'coursecat')->purge(); context_coursecat::instance($id); } } and a version.php. Re-install your PHPUnit tables, and run the unit tests.

    Description

      Core unit tests must not hard-code things like context ids. If you install an Add-on like mod_oublog, then logs of core unit tests fail.

      I'm fixing this.

      Attachments

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43440 Wrong ids in unit tests - causes failures if an add-on a contexts on install

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-43835 Use unique sequence values on database reset to pick unit testing mistakes

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed
          is a regression caused by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-31683 mod_assign_get_assignments

          • Major - Major loss of function, incorrect output
          • Closed

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDL-31830 Replacement for the course and category management pages

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-40049 Replace add_to_log with an event trigger - mod_choice

          • Major - Major loss of function, incorrect output
          • Closed

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-40060 Replace add_to_log with an event trigger - mod_book

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              timhunt Tim Hunt
              timhunt Tim Hunt
              Petr Skoda Petr Skoda
              Marina Glancy Marina Glancy
              Ankit Agarwal Ankit Agarwal
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/Mar/14