Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43929

Manual Grading - Comment disappears if grade (or mark) number exceeds the maximum

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.2, 2.6
    • Fix Version/s: 2.5.5, 2.6.2
    • Component/s: Quiz
    • Labels:
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide
      1. Create a quiz with various types of question, including an essay.
      2. Make a couple of attempts as a student.
      3. As teacher/admin, review a student's attempt.
      4. Click a Make comment or override grade link.
      5. Type in a comment, and enter a grade that is out-of-range.
      6. Click save. The page should be re-displayed with a validation error. Verify that your commend has not been lost.
      7. Edit the grade to be in range, then save again.
      8. Verify the comment and grade is saved.
      9. Repeat the previous few points using Results -> Manual grading pages, rather than the starting from the attempt review page.
      Show
      Create a quiz with various types of question, including an essay. Make a couple of attempts as a student. As teacher/admin, review a student's attempt. Click a Make comment or override grade link. Type in a comment, and enter a grade that is out-of-range. Click save. The page should be re-displayed with a validation error. Verify that your commend has not been lost. Edit the grade to be in range, then save again. Verify the comment and grade is saved. Repeat the previous few points using Results -> Manual grading pages, rather than the starting from the attempt review page.

      Description

      If you are using the manual grading feature for a quiz and type in a comment and then accidentally type in a mark/grade that exceed the maximum (for example 4/2, instead of 2/2), the system clears out the comment and then throws an error. Ideally, it should save the comment and then throw the error.

      Support Forum thread related to this:
      https://moodle.org/mod/forum/discuss.php?d=253143

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            rlhugo Russell Hugo
            Peer reviewer:
            Mark Nelson Mark Nelson
            Integrator:
            Sam Hemelryk Sam Hemelryk
            Tester:
            Jason Fowler Jason Fowler
            Participants:
            Component watchers:
            Tim Hunt, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Mar/14