Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43992

moodle-core-notification-confirm always confirms on <Enter> key

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      • Open a course page
      • Click Backup
      • Click Cancel
      • Tab to the [X] button, and hit the <Return> key
        • Confirm the dialogue closes but the page does not redirect
      • Click Cancel to re-open the dialogue
      • Tab to the 'Stay' button, and hit the <Return> key
        • Confirm the dialogue closes but the page does not redirect
      • Click Cancel to re-open the dialogue
      • Tab to the 'Cancel' button, and hit the <Return> key
        • Confirm that the backup was cancelled
      • Start a new backup
      • Click Cancel
      • While nothing is selected (the default), press <Return>
        • Confirm that the nothing happened
      Show
      Open a course page Click Backup Click Cancel Tab to the [X] button, and hit the <Return> key Confirm the dialogue closes but the page does not redirect Click Cancel to re-open the dialogue Tab to the 'Stay' button, and hit the <Return> key Confirm the dialogue closes but the page does not redirect Click Cancel to re-open the dialogue Tab to the 'Cancel' button, and hit the <Return> key Confirm that the backup was cancelled Start a new backup Click Cancel While nothing is selected (the default), press <Return> Confirm that the nothing happened
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-43992-master
    • Sprint:
      FRONTEND Sprint 9

      Description

      On a moodle-core-notification-confirm, when tabing on the cancel button or the close button, the <Enter> key triggers the "Confirm" button, this is wrong, it should trigger the cancel button.

      This probably needs to be backported

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Lyons
              Reporter:
              fred Frédéric Massart
              Peer reviewer:
              Frédéric Massart Frédéric Massart
              Integrator:
              Sam Hemelryk Sam Hemelryk
              Tester:
              Petr Skoda Petr Skoda
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Mar/14