Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43992

moodle-core-notification-confirm always confirms on <Enter> key

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      • Open a course page
      • Click Backup
      • Click Cancel
      • Tab to the [X] button, and hit the <Return> key
        • Confirm the dialogue closes but the page does not redirect
      • Click Cancel to re-open the dialogue
      • Tab to the 'Stay' button, and hit the <Return> key
        • Confirm the dialogue closes but the page does not redirect
      • Click Cancel to re-open the dialogue
      • Tab to the 'Cancel' button, and hit the <Return> key
        • Confirm that the backup was cancelled
      • Start a new backup
      • Click Cancel
      • While nothing is selected (the default), press <Return>
        • Confirm that the nothing happened
      Show
      Open a course page Click Backup Click Cancel Tab to the [X] button, and hit the <Return> key Confirm the dialogue closes but the page does not redirect Click Cancel to re-open the dialogue Tab to the 'Stay' button, and hit the <Return> key Confirm the dialogue closes but the page does not redirect Click Cancel to re-open the dialogue Tab to the 'Cancel' button, and hit the <Return> key Confirm that the backup was cancelled Start a new backup Click Cancel While nothing is selected (the default), press <Return> Confirm that the nothing happened
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-43992-master
    • Pull Master Diff URL:
    • Sprint:
      FRONTEND Sprint 9

      Description

      On a moodle-core-notification-confirm, when tabing on the cancel button or the close button, the <Enter> key triggers the "Confirm" button, this is wrong, it should trigger the cancel button.

      This probably needs to be backported

        Attachments

          Issue Links

          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43997 Dialogues no longer show automatically, or modally

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-42428 Update M.util.show_confirm_dialog() to use moodle-core-notification

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              fred Frédéric Massart
              Peer reviewer:
              Frédéric Massart
              Integrator:
              Sam Hemelryk
              Tester:
              Petr Skoda
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Mar/14