Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43997

Dialogues no longer show automatically, or modally

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.7
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide
      • Open a course
      • Click 'Backup'
      • Click on the Cancel button
        • Confirm that the dialogue is centred
        • Confirm that the dialogue is modal and has a lightbox
      • Edit lib/ajax/getsiteadminbranch.php
      • echo some content out after ajax_capture_output();
      • Refresh any page
      • Expand the Site administration
        • Confirm that an error was displayed centred, and modal
      • Change your echo to:

        throw new moodle_exception('banana');
        

      • Refresh any page
      • Expand the Site administration
        • Confirm that an error was displayed centred, and modal
      • Open your JS console and enter:

        Y.use('moodle-core-notification');
        

      • Confirm that each of the following displays a dialogue immediately, centred, and modal (with lightbox
        • ajaxException:

          foo = new M.core.ajaxException({});
          

        • alert

          foo.destroy();
          foo = new M.core.alert({});
          

        • confirm

          foo.destroy();
          foo = new M.core.confirm({});
          

        • exception

          foo.destroy();
          foo = new M.core.exception({});
          

      • Confirm that the following does not display a new dialogue

        foo.destroy();
        foo = new M.core.dialogue({});
        

      • Now open it and confirm that it is:
        • centred
        • not modal (has no lightbox)

          foo.show();
          

      Show
      Open a course Click 'Backup' Click on the Cancel button Confirm that the dialogue is centred Confirm that the dialogue is modal and has a lightbox Edit lib/ajax/getsiteadminbranch.php echo some content out after ajax_capture_output(); Refresh any page Expand the Site administration Confirm that an error was displayed centred, and modal Change your echo to: throw new moodle_exception('banana'); Refresh any page Expand the Site administration Confirm that an error was displayed centred, and modal Open your JS console and enter: Y.use('moodle-core-notification'); Confirm that each of the following displays a dialogue immediately, centred, and modal (with lightbox ajaxException: foo = new M.core.ajaxException({}); alert foo.destroy(); foo = new M.core.alert({}); confirm foo.destroy(); foo = new M.core.confirm({}); exception foo.destroy(); foo = new M.core.exception({}); Confirm that the following does not display a new dialogue foo.destroy(); foo = new M.core.dialogue({}); Now open it and confirm that it is: centred not modal (has no lightbox) foo.show();
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-43997-master
    • Story Points:
      8

      Description

      Since MDL-43262 and MDL-43259 landed in master, we no longer show some types of dialogue automatically or modally.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Lyons
              Reporter:
              dobedobedoh Andrew Lyons
              Peer reviewer:
              Petr Skoda Petr Skoda
              Integrator:
              Sam Hemelryk Sam Hemelryk
              Tester:
              Jérôme Mouneyrac Jérôme Mouneyrac
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14