Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44004

Rubrics - Warning detected when adding a level with Javascript disabled

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Define a new rubric in advanced grading (assignment)
      2. Turn off Javascript
      3. Add a new level in the first criterion
      4. Make sure a new level is added and has a value higher than all the other levels
      5. Change the value of any level and add a new level
      6. Make sure a new level is added and has a value higher than all of the other levels

      PS: This interface looks horrible in Clean

      Show
      Define a new rubric in advanced grading (assignment) Turn off Javascript Add a new level in the first criterion Make sure a new level is added and has a value higher than all the other levels Change the value of any level and add a new level Make sure a new level is added and has a value higher than all of the other levels PS: This interface looks horrible in Clean
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-44004-master

      Description

      Writing automated tests for rubrics (MDL-42404) with JS disabled I've noticed that, when I define a new rubric and I add a new level to the default 1st criterion I see the following PHP warnings.

      ( ! ) Warning: Illegal string offset 'score' in /home/davidm/Desktop/moodlecode/master/grade/grading/form/rubric/rubriceditor.php on line 223
      Call Stack
      #	Time	Memory	Function	Location
      1	0.0003	268608	{main}( )	../edit.php:0
      2	0.2056	28046896	moodleform->is_validated( )	../edit.php:52
      3	0.2056	28044472	moodleform->validate_defined_fields( )	../formslib.php:504
      4	0.2057	28047472	MoodleQuickForm->exportValues( )	../formslib.php:554
      5	0.2058	28051208	MoodleQuickForm_rubriceditor->exportValue( )	../formslib.php:1939
      6	0.2058	28051272	MoodleQuickForm_rubriceditor->prepare_data( )	../rubriceditor.php:369
      

      ( ! ) Warning: Illegal string offset 'score' in /home/davidm/Desktop/moodlecode/master/grade/grading/form/rubric/rubriceditor.php on line 223
      Call Stack
      #	Time	Memory	Function	Location
      1	0.0003	268608	{main}( )	../edit.php:0
      2	0.3411	35007320	moodleform->display( )	../edit.php:59
      3	0.3411	35007416	HTML_QuickForm_DHTMLRulesTableless->display( )	../formslib.php:929
      4	0.3411	35007944	HTML_Common->display( )	../DHTMLRulesTableless.php:204
      5	0.3411	35007976	HTML_QuickForm->toHtml( )	../Common.php:435
      6	0.3411	35008112	MoodleQuickForm->accept( )	../QuickForm.php:1675
      7	0.3413	35009744	HTML_QuickForm->accept( )	../formslib.php:1702
      8	0.4187	36292920	HTML_QuickForm_element->accept( )	../QuickForm.php:1632
      9	0.4187	36293048	MoodleQuickForm_Renderer->renderElement( )	../element.php:403
      10	0.4188	36294104	HTML_QuickForm_Renderer_Tableless->renderElement( )	../formslib.php:2781
      11	0.4189	36294760	MoodleQuickForm_rubriceditor->toHtml( )	../Tableless.php:183
      12	0.4205	36449504	MoodleQuickForm_rubriceditor->prepare_data( )	../rubriceditor.php:105
      

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/May/14