Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44020

Add core_calendar_get_calendar_events function to the moodle mobile core service

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.4, 2.6.1, DEV backlog
    • Fix Version/s: 2.5.5, 2.6.2
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide
      • Remember to upgrade your Moodle installation (the version number is bumped in the commit)
      • Once upgraded, go to Home / Site administration / Plugins / Web services / External services / Moodle Mobile service / Functions and check that the core_calendar_get_calendar_events function is listed
      Show
      Remember to upgrade your Moodle installation (the version number is bumped in the commit) Once upgraded, go to Home / Site administration / Plugins / Web services / External services / Moodle Mobile service / Functions and check that the core_calendar_get_calendar_events function is listed
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-44020-MASTER

      Description

      We are planning to add a new option in the official Mobile app "Calendar events" so we need to add the core_calendar_get_calendar_events to the mobile service in order to be able to consume that webservice from the mobile app

      To clarify, the function already exists, we are going to only the name of the function in the mobile service settings

      I'm going to request backport of this configuration change to 2.5 and 2.6, this is not a bug and not a new feature

      I raised a policy ticket asking about how to proceed but it still not answered see https://tracker.moodle.org/browse/MDL-43847

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment - - edited

            +1, i cannot imagine any problem about expanding the $mobile definition to embrace new services (functions) that are already there.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - - edited +1, i cannot imagine any problem about expanding the $mobile definition to embrace new services (functions) that are already there.
            Hide
            cibot CiBoT added a comment -

            Results for MDL-44020

            • Remote repository: git://github.com/jleyva/moodle.git
            Show
            cibot CiBoT added a comment - Results for MDL-44020 Remote repository: git://github.com/jleyva/moodle.git Remote branch MDL-44020 -STABLE-25 to be integrated into upstream MOODLE_25_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1142 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1142/artifact/work/smurf.html Remote branch MDL-44020 -STABLE-26 to be integrated into upstream MOODLE_26_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1143 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1143/artifact/work/smurf.html Remote branch MDL-44020 to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1144 Error: The MDL-44020 branch at git://github.com/jleyva/moodle.git does not apply clean to master
            Hide
            cibot CiBoT added a comment -

            Results for MDL-44020

            • Remote repository: git://github.com/jleyva/moodle.git
            Show
            cibot CiBoT added a comment - Results for MDL-44020 Remote repository: git://github.com/jleyva/moodle.git Remote branch MDL-44020 -STABLE-25 to be integrated into upstream MOODLE_25_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1145 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1145/artifact/work/smurf.html Remote branch MDL-44020 -STABLE-26 to be integrated into upstream MOODLE_26_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1146 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1146/artifact/work/smurf.html Remote branch MDL-44020 -MASTER to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1147 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1147/artifact/work/smurf.html
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Sending to integration, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Sending to integration, thanks!
            Hide
            cibot CiBoT added a comment -

            Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

            Show
            cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Juan, this has been integrated now.
            As Eloy mentioned surely no harm in backporting this.
            Noting I did make two additional commits one to 26 and the other to 25 to bump the version.
            Please rebase in the future.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Juan, this has been integrated now. As Eloy mentioned surely no harm in backporting this. Noting I did make two additional commits one to 26 and the other to 25 to bump the version. Please rebase in the future.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This is working as expected.

            Tested for 2.5, 2.6 and master.

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - This is working as expected. Tested for 2.5, 2.6 and master. Test passed.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Fetch your remotes, prune them,
            clean your integrated branches and say "Ahem".

            Rebase your ongoing stuff, keep conflicts away
            don't forget to test the code and we'll love you again.

            Thanks, closing!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Fetch your remotes, prune them, clean your integrated branches and say "Ahem". Rebase your ongoing stuff, keep conflicts away don't forget to test the code and we'll love you again. Thanks, closing!
            Hide
            mudrd8mz David Mudrak added a comment -

            Even though you believe that adding yet another function to a WS causes no harm, one might as well see the in-built web service as a part of the Moodle API. From that point of view, extending the WS violates the "stable API" rule conceptually. I am aware of the fact that the mobile app gets special attention and that it is important for political reasons. But we should be clear on what is allowed and what is not, if nothing that for future reference.

            Show
            mudrd8mz David Mudrak added a comment - Even though you believe that adding yet another function to a WS causes no harm, one might as well see the in-built web service as a part of the Moodle API. From that point of view, extending the WS violates the "stable API" rule conceptually. I am aware of the fact that the mobile app gets special attention and that it is important for political reasons. But we should be clear on what is allowed and what is not, if nothing that for future reference.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Mar/14