Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44079

Pressing escape in nested modal dialogues should only close the top dialogue

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      • Open the login page
      • Press the [?] button to display help
      • Press [escape]
        • Confirm that the tooltip closed
      • Re-open
      • Click on the page background
        • Confirm that the tooltip closed
      • Re-open
      • Click on the [X] button with the keyboard
        • Confirm that the tooltip closed
      • Re-open
      • Click on the [X] button with the mouse
        • Confirm that the tooltip closed
      • Login
      • From Administration, choose -> My profiles settings -> Edit profile
      • In the 'Description' editor, click the 'Insert media' button, and then press the button to open the filepicker
      • Press [escape]
        • Confirm that only the filepicker closed
      • Re-open
      • Press [X]
        • Confirm that only the filepicker closed
      • Re-open
      • Select wikimedia and search for something (e.g. 'lolcat')
      • Select a cat (the preview dialogue should open)
      • Press [escape]
        • Confirm that only the preview box closed
      • Re-open
      • Press [X]
        • Confirm that only the preview box closed
      • Re-open
      • Press [Cancel]
        • Confirm that only the preview box closed
      • Re-open
      • Press [Select]
        • Confirm that both the Preview and the Filepicker closed
      • Open a course, turn editing on, create an assignment
      • As a student, submit something to it (a PDF)
      • As a tutor, grade the submission and open the PDF editor
      • Press [escape]
        • Confirm that only the PDF editor closed
      • Re-open
      • Press [X]
        • Confirm that only the PDF editor closed
      • Re-open
      • Open the Comment Search dialogue
      • Press [escape]
        • Confirm that only the PDF editor closed
      • Re-open
      • Select the text box
      • Press [escape]
        • Confirm that the dialogue did not close, but the text box lost focus
      • Press [X]
        • Confirm that only the PDF editor closed
      Show
      Open the login page Press the [?] button to display help Press [escape] Confirm that the tooltip closed Re-open Click on the page background Confirm that the tooltip closed Re-open Click on the [X] button with the keyboard Confirm that the tooltip closed Re-open Click on the [X] button with the mouse Confirm that the tooltip closed Login From Administration, choose -> My profiles settings -> Edit profile In the 'Description' editor, click the 'Insert media' button, and then press the button to open the filepicker Press [escape] Confirm that only the filepicker closed Re-open Press [X] Confirm that only the filepicker closed Re-open Select wikimedia and search for something (e.g. 'lolcat') Select a cat (the preview dialogue should open) Press [escape] Confirm that only the preview box closed Re-open Press [X] Confirm that only the preview box closed Re-open Press [Cancel] Confirm that only the preview box closed Re-open Press [Select] Confirm that both the Preview and the Filepicker closed Open a course, turn editing on, create an assignment As a student, submit something to it (a PDF) As a tutor, grade the submission and open the PDF editor Press [escape] Confirm that only the PDF editor closed Re-open Press [X] Confirm that only the PDF editor closed Re-open Open the Comment Search dialogue Press [escape] Confirm that only the PDF editor closed Re-open Select the text box Press [escape] Confirm that the dialogue did not close, but the text box lost focus Press [X] Confirm that only the PDF editor closed
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-44079-master
    • Story Points:
      5
    • Sprint:
      FRONTEND Sprint 9

      Description

      If you open a filepicker, search for and preview a file, then press escape, all modals are closed instead of just the top one.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Mar/14