# Integrate Atto

## Details

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.7
• Fix Version/s:
• Component/s:
• Labels:
• Testing Instructions:
Hide

Run all the behat tests.
In all browsers do exploratory testing on all the plugins.

Notes: There are known issues that are not yet fixed - but none that are considered blockers - check the "Make Atto the default Moodle text editor" Epic for duplicates before reporting issues.

Show
Run all the behat tests. In all browsers do exploratory testing on all the plugins. Notes: There are known issues that are not yet fixed - but none that are considered blockers - check the "Make Atto the default Moodle text editor" Epic for duplicates before reporting issues.
• Affected Branches:
MOODLE_27_STABLE
• Fixed Branches:
MOODLE_27_STABLE
• Epic Link:
• Pull from Repository:
• Pull Master Branch:
MDL-44084-master
• Sprint:
FRONTEND Sprint 10
• Sprint:
FRONTEND Sprint 10

## Description

Final blocker issue for all chained issues in the epic.

## Activity

Hide
moodle.com added a comment -

Splitting this into two issues to integrate atto and then make it default later.

Show
moodle.com added a comment - Splitting this into two issues to integrate atto and then make it default later.
Hide
Damyon Wiese added a comment -

All the blockers are done. I'm sending this for integration now. Cross everything!

Show
Damyon Wiese added a comment - All the blockers are done. I'm sending this for integration now. Cross everything!
Hide
CiBoT added a comment -

Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

Show
CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
Hide
Marina Glancy added a comment -

 Fatal error: Class 'editor_atto\plugininfo\moodle_url' not found in /home/marina/repositories/int_master/moodle/lib/editor/atto/classes/plugininfo/atto.php on line 46 

Show
Marina Glancy added a comment - Fatal error: Class 'editor_atto\plugininfo\moodle_url' not found in /home/marina/repositories/int_master/moodle/lib/editor/atto/classes/plugininfo/atto.php on line 46
Hide
Marina Glancy added a comment -

when I corrected the above, half of atto plugins are listed as "Add-ons" on /admin/plugins.php

Show
Marina Glancy added a comment - when I corrected the above, half of atto plugins are listed as "Add-ons" on /admin/plugins.php
Hide
Marina Glancy added a comment -

toolbar and equation subplugins do not have "Settings" link on /admin/settings.php?section=editorsettingsatto but the item is present in navigation

Show
Marina Glancy added a comment - toolbar and equation subplugins do not have "Settings" link on /admin/settings.php?section=editorsettingsatto but the item is present in navigation
Hide
Damyon Wiese added a comment -

Thanks Marina,

I added a commit to fix the first 2 points.

The last one (missing settings links for atto plugins with settings) - bah - this is (I think) because none of those plugins define their own plugininfo. plugininfo is a bit of voodoo to me and I don't want to try and do a quick fix there - so I'll create a new issue for it.

Show
Damyon Wiese added a comment - Thanks Marina, I added a commit to fix the first 2 points. The last one (missing settings links for atto plugins with settings) - bah - this is (I think) because none of those plugins define their own plugininfo. plugininfo is a bit of voodoo to me and I don't want to try and do a quick fix there - so I'll create a new issue for it.
Hide
Damyon Wiese added a comment -

MDL-44784 created for the settings links.

Show
Damyon Wiese added a comment - MDL-44784 created for the settings links.
Hide
Marina Glancy added a comment -

It looks like Damyon forgot to push commit. Here is one:
https://github.com/marinaglancy/moodle/commit/9ef3a3e7946475985f94aa17ca4286110b0fc0fc

Show
Marina Glancy added a comment - It looks like Damyon forgot to push commit. Here is one: https://github.com/marinaglancy/moodle/commit/9ef3a3e7946475985f94aa17ca4286110b0fc0fc
Hide
Damyon Wiese added a comment -

Arg - sorry - I pushed to the atto repo - not the one listed here.

Anyway Marinas commit was the same so I cherrypicked that one onto the branch and pushed it both places.

Summary - the fix is on the branch (thanks Marina).

Show
Damyon Wiese added a comment - Arg - sorry - I pushed to the atto repo - not the one listed here. Anyway Marinas commit was the same so I cherrypicked that one onto the branch and pushed it both places. Summary - the fix is on the branch (thanks Marina).
Hide
Eloy Lafuente (stronk7) added a comment -

+1 to push this, no matter it fu... err, breaks everything.

Show
Eloy Lafuente (stronk7) added a comment - +1 to push this, no matter it fu... err, breaks everything.
Hide
Marina Glancy added a comment -

integrated!

Show
Marina Glancy added a comment - integrated!
Hide
Marina Glancy added a comment -

(again)

Show
Marina Glancy added a comment - (again)
Hide
Eloy Lafuente (stronk7) added a comment - - edited

(thanks Marina, and sorry for the confusion, re-reading the logs I understood you were finishing the commits and was going to proceed, while clearly it was me the one that had got the baton)

Congrats everybody!

Show
Eloy Lafuente (stronk7) added a comment - - edited (thanks Marina, and sorry for the confusion, re-reading the logs I understood you were finishing the commits and was going to proceed, while clearly it was me the one that had got the baton) Congrats everybody!
Hide
Marina Glancy added a comment -

BEHAT failure!

 (::) failed steps (::)   01. M.editor_atto is undefined  Build info: version: '2.39.0', revision: 'ff23eac', time: '2013-12-16 16:11:15'  System info: host: 'marina-desktop', ip: '127.0.1.1', os.name: 'Linux', os.arch: 'amd64', os.version: '3.11.0-18-generic', java.version: '1.7.0_51'  Driver info: driver.version: unknown  In step Given I set the following fields to these values:'. # behat_forms::i_set_the_following_fields_to_these_values()  From scenario Submit a PDF file as a student and annotate the PDF as a teacher'. # /home/marina/repositories/int_master/moodle/mod/assign/feedback/editpdf/tests/behat/annotate_pdf.feature:8  Of feature In an assignment, teacher can annotate PDF files during grading'. # /home/marina/repositories/int_master/moodle/mod/assign/feedback/editpdf/tests/behat/annotate_pdf.feature 

Show
Marina Glancy added a comment - BEHAT failure! (::) failed steps (::)   01. M.editor_atto is undefined Build info: version: '2.39.0', revision: 'ff23eac', time: '2013-12-16 16:11:15' System info: host: 'marina-desktop', ip: '127.0.1.1', os.name: 'Linux', os.arch: 'amd64', os.version: '3.11.0-18-generic', java.version: '1.7.0_51' Driver info: driver.version: unknown In step Given I set the following fields to these values:'. # behat_forms::i_set_the_following_fields_to_these_values() From scenario Submit a PDF file as a student and annotate the PDF as a teacher'. # /home/marina/repositories/int_master/moodle/mod/assign/feedback/editpdf/tests/behat/annotate_pdf.feature:8 Of feature In an assignment, teacher can annotate PDF files during grading'. # /home/marina/repositories/int_master/moodle/mod/assign/feedback/editpdf/tests/behat/annotate_pdf.feature
Hide
Marina Glancy added a comment -

I need to change the status of the issue to "Problems during testing" because of behat failure. But please do continue manual tests. Thanks

Show
Marina Glancy added a comment - I need to change the status of the issue to "Problems during testing" because of behat failure. But please do continue manual tests. Thanks
Hide
Rajesh Taneja added a comment -

Hello Marina/Eloy,

Can you please pull https://github.com/rajeshtaneja/moodle/commit/b033c163900c1318e41e39011e34a95d181a9632 as this is breaking behat.

Show
Rajesh Taneja added a comment - Hello Marina/Eloy, Can you please pull https://github.com/rajeshtaneja/moodle/commit/b033c163900c1318e41e39011e34a95d181a9632 as this is breaking behat.
Hide
Marina Glancy added a comment -

fix pulled thanks

Show
Marina Glancy added a comment - fix pulled thanks
Hide
Rajesh Taneja added a comment -
Show
Rajesh Taneja added a comment - Testing is in progress, status can be seen at https://tracker.moodle.org/secure/ViewSession.jspa?testSessionId=10665&origin=nav
Hide
Rajesh Taneja added a comment -

Hello Marina,

Can you please pull this patch https://github.com/rajeshtaneja/moodle/commit/3e469992a1ccd014c28ac235022b6a5909d63463
It is fixing Atto issue for out-of-focus and also wiki failure.

Show
Rajesh Taneja added a comment - Hello Marina, Can you please pull this patch https://github.com/rajeshtaneja/moodle/commit/3e469992a1ccd014c28ac235022b6a5909d63463 It is fixing Atto issue for out-of-focus and also wiki failure.
Hide
Rajesh Taneja added a comment -

Thanks Damyon and Frontend team for working on awesome editor.

Also, thanks to everyone involved in testing Atto https://tracker.moodle.org/secure/ViewSession.jspa?testSessionId=10665&origin=nav

Passing ...

Show
Rajesh Taneja added a comment - Thanks Damyon and Frontend team for working on awesome editor. Also, thanks to everyone involved in testing Atto https://tracker.moodle.org/secure/ViewSession.jspa?testSessionId=10665&origin=nav Passing ...
Hide
Eloy Lafuente (stronk7) added a comment -

Clothes and manners do
not make the man; but,
when he is made, they
greatly improve his appearance.

---- Henry Ward Beecher

What a week, your changes are now part of Moodle, well done!

Closing, thanks!

Show
Eloy Lafuente (stronk7) added a comment - Clothes and manners do not make the man; but, when he is made, they greatly improve his appearance. ---- Henry Ward Beecher What a week, your changes are now part of Moodle, well done! Closing, thanks!
Hide
Rajesh Taneja added a comment -

This has been covered by Behat, but adding qa_test_required, as this should be checked manually as well.

Show
Rajesh Taneja added a comment - This has been covered by Behat, but adding qa_test_required, as this should be checked manually as well.
Hide
Mary Cooch added a comment -
Show
Mary Cooch added a comment - Just removing the qa_test_required as we had some QA tests done for 2.7 - https://tracker.moodle.org/browse/MDLQA-6683 and https://tracker.moodle.org/browse/MDLQA-6685 and https://tracker.moodle.org/browse/MDLQA-6686 and https://tracker.moodle.org/browse/MDLQA-6687

## People

• Assignee:
Damyon Wiese
Reporter:
Damyon Wiese
Integrator:
Marina Glancy
Tester:
Rajesh Taneja
Participants:
• Votes:
0 Vote for this issue
Watchers:
6 Start watching this issue

## Dates

• Created:
Updated:
Resolved:
Fix Release Date:
12/May/14