Moodle
  1. Moodle
  2. MDL-44095

theme notes refer to core_maintenance_renderer not core_renderer_maintenance

    Details

      Description

      This file:

      https://github.com/moodle/moodle/blob/master/theme/upgrade.txt

      has several references to core_maintenance_renderer:

      • core_maintenance_renderer::block
      • core_maintenance_renderer::blocks
      • core_maintenance_renderer::blocks_for_regions
      • core_maintenance_renderer::course_header
      • core_maintenance_renderer::course_footer
      • core_maintenance_renderer::course_content_header
      • core_maintenance_renderer::course_content_footer
      • core_maintenance_renderer::custom_menu
      • core_maintenance_renderer::file_picker
      • core_maintenance_renderer::htmllize_file_tree
      • core_maintenance_renderer::lang_menu
      • core_maintenance_renderer::login_info
      • core_maintenance_renderer::user_picture

      but it's actually core_renderer_maintenance, which confused me when I was searching for it.

        Gliffy Diagrams

          Activity

          Hide
          Mary Evans added a comment -

          Lots of related stuff before and after this point...
          https://github.com/moodle/moodle/blob/master/lib/outputrenderers.php#L3829

          Show
          Mary Evans added a comment - Lots of related stuff before and after this point... https://github.com/moodle/moodle/blob/master/lib/outputrenderers.php#L3829
          Hide
          David Scotson added a comment -

          Yeah, that's the actual class, they just got two bits of the name swapped round in the upgrade.txt:

          https://github.com/moodle/moodle/blob/master/lib/outputrenderers.php#L3828-L4023

          Show
          David Scotson added a comment - Yeah, that's the actual class, they just got two bits of the name swapped round in the upgrade.txt: https://github.com/moodle/moodle/blob/master/lib/outputrenderers.php#L3828-L4023
          Show
          Shashikant vaishnav added a comment - Here is the git diff :- https://github.com/shashirepo/moodle/compare/moodle:master...patch-1
          Hide
          Shashikant vaishnav added a comment -

          typo with class name notes fixed, here is the git diff url :- https://github.com/shashirepo/moodle/compare/moodle:master...patch-1

          Show
          Shashikant vaishnav added a comment - typo with class name notes fixed, here is the git diff url :- https://github.com/shashirepo/moodle/compare/moodle:master...patch-1
          Hide
          Mary Evans added a comment -

          Did someone add me as Peer Reviewer? It's usual to ask isn't it. Also it looks like a peer review is in progress.

          Show
          Mary Evans added a comment - Did someone add me as Peer Reviewer? It's usual to ask isn't it. Also it looks like a peer review is in progress.
          Hide
          Mary Evans added a comment -

          Hi Shashikant,

          I see in the history that you set me as Peer Reviewer and also set it to Peer Review in progress. It is usual for the Peer Reviewer to activate that setting.

          Also if you want to take on this task then you may as well assign yourself to this tracker too. And fill in the relevant parts for the form with the repository name/branch and branch diff.

          Thanks
          Mary

          Show
          Mary Evans added a comment - Hi Shashikant, I see in the history that you set me as Peer Reviewer and also set it to Peer Review in progress. It is usual for the Peer Reviewer to activate that setting. Also if you want to take on this task then you may as well assign yourself to this tracker too. And fill in the relevant parts for the form with the repository name/branch and branch diff. Thanks Mary
          Hide
          Shashikant vaishnav added a comment -

          Hello Mary,

          Looks like I don't have option to assign it to myself, let me ask for it to Michael.

          Thanks.

          Show
          Shashikant vaishnav added a comment - Hello Mary, Looks like I don't have option to assign it to myself, let me ask for it to Michael. Thanks.
          Hide
          Mary Evans added a comment -

          Looks OK to me...sorry I missed this it should have been sent for integration,last week!

          Show
          Mary Evans added a comment - Looks OK to me...sorry I missed this it should have been sent for integration,last week!
          Hide
          Mary Evans added a comment -

          Can you rebase this and also make a master branch? Thanks

          Show
          Mary Evans added a comment - Can you rebase this and also make a master branch? Thanks
          Hide
          Shashikant vaishnav added a comment -

          Hello Mary,

          I am getting lots of merge conflicts while re-basing. How can I get them resolved. Already tried looking around web but still no luck.

          thanks!

          Show
          Shashikant vaishnav added a comment - Hello Mary, I am getting lots of merge conflicts while re-basing. How can I get them resolved. Already tried looking around web but still no luck. thanks!
          Hide
          Shashikant vaishnav added a comment - - edited

          Hello Mary,

          Just rebased, and updated the master fix urls, Please sent it for integration.

          thanks!

          Show
          Shashikant vaishnav added a comment - - edited Hello Mary, Just rebased, and updated the master fix urls, Please sent it for integration. thanks!
          Hide
          CiBoT added a comment -

          Results for MDL-44095

          • Error: the repository field is empty. Nothing was checked.
          Show
          CiBoT added a comment - Results for MDL-44095 Error: the repository field is empty. Nothing was checked.
          Hide
          Dan Poltawski added a comment -

          I'm sending this for integration (looks good to me). Adding Mary as the peer reviewer as she seems to have been doing all the work on it

          Show
          Dan Poltawski added a comment - I'm sending this for integration (looks good to me). Adding Mary as the peer reviewer as she seems to have been doing all the work on it
          Hide
          CiBoT added a comment -

          Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

          Show
          CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
          Hide
          Dan Poltawski added a comment -

          Thanks Shashikant, integrated to master and 26

          Show
          Dan Poltawski added a comment - Thanks Shashikant, integrated to master and 26
          Hide
          Rajesh Taneja added a comment -

          Hello Shashikant,
          Can you please add testing instructions.

          Show
          Rajesh Taneja added a comment - Hello Shashikant, Can you please add testing instructions.
          Hide
          Dan Poltawski added a comment -

          I've done that.

          Show
          Dan Poltawski added a comment - I've done that.
          Hide
          Damyon Wiese added a comment -

          Well the class name is correct on both branches and it is applied to the correct versions to passing.

          Thanks!

          Show
          Damyon Wiese added a comment - Well the class name is correct on both branches and it is applied to the correct versions to passing. Thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The price of success is hard work,
          dedication to the job at hand,
          and the determination that whether we win or lose,
          we have applied the best of ourselves to the task at hand.

          Vince Lombardi

          This is now part of Moodle, your favorite non-frameworkial LMS, LOL. Thanks, closing!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The price of success is hard work, dedication to the job at hand, and the determination that whether we win or lose, we have applied the best of ourselves to the task at hand. Vince Lombardi This is now part of Moodle, your favorite non-frameworkial LMS, LOL. Thanks, closing! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: