Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44141

Completion system updates data during restore

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Specifically test this in all the branches (25, 26 and master), please.

      0. (Completion must be enabled in Moodle features admin option.)
      1. Create a new course, with completion enabled.
      2. Enrol a test account on the course.
      3. Add a quiz, set to be marked complete when user gets a grade.
      4. Add one true/false question to the quiz.
      5. Log in as the test user.
      6. Complete the quiz.
      7. Back as admin user, look at the completion report for the course and note the time that the user completed it.
      8. Do a backup of course using default settings.
      9. Restore to new course using default settings.
      10. Look at completion report.

      EXPECTED: The time against the user should be the same as noted in step 7.
      BEFORE FIX: The time is set to the time of the restore.

      Show
      Specifically test this in all the branches (25, 26 and master), please. 0. (Completion must be enabled in Moodle features admin option.) 1. Create a new course, with completion enabled. 2. Enrol a test account on the course. 3. Add a quiz, set to be marked complete when user gets a grade. 4. Add one true/false question to the quiz. 5. Log in as the test user. 6. Complete the quiz. 7. Back as admin user, look at the completion report for the course and note the time that the user completed it. 8. Do a backup of course using default settings. 9. Restore to new course using default settings. 10. Look at completion report. EXPECTED: The time against the user should be the same as noted in step 7. BEFORE FIX: The time is set to the time of the restore.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-44141-master
    • Pull Master Diff URL:

      Description

      After a course restore, the activity completion time is set to the restore time. This way all the original activity completion time are lost.

      How to reproduce this issue: with completion tracking enabled

      • Create a course
      • Add a quiz activity
      • Set activity completion: Completion tracking -> "Show activity as complete when conditions are met" and check "Student must receive a grade to complete this activity".
      • Add this activity in course Course completion.
      • Enrol some user to this course
      • Complete the activity with an user.
      • Check in Reports -> Activity completion that the activity is completed and remember the Completed time.
      • Backup this course.
      • Restore the course.
      • In the new course check in Reports -> Activity completion: the completion time is changes and is now set to the restore time

        Attachments

          Issue Links

          blocks

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-44106 use 'restore' and 'ws' origin in logged events

          • Major - Major loss of function, incorrect output
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-44070 Conditional availability: Enhancements including OR conditions, plugins

          • Major - Major loss of function, incorrect output
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-44428 Detecting restore in notify changed in grade no longer works

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              Assignee:
              quen Sam Marshall
              Reporter:
              ghigio Federico
              Peer reviewer:
              Dan Poltawski
              Integrator:
              Marina Glancy
              Tester:
              Damyon Wiese
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14