Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44142

Cohorts 'Current users' list does not obey maxusersperpage.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.4
    • Fix Version/s: 2.5.5, 2.6.2
    • Component/s: Cohorts
    • Labels:
    • Testing Instructions:
      Hide

      Prerequisite:

      • Site with more than 100 users
      • Log in as admin
      • Update maxusersperpage to something > 100 (Site administration ► Users ► Permissions ► User policies)

      Test user selector in cohort

      1. Create cohort (Site administration ► Users ► Accounts ► Cohorts)

      2. Click "Assign" icon (Site administration ► Users ► Accounts ► Cohorts ► Assign)

      3. Assign more than 100 users but less than number set for maxusersperpage above

      4. Make sure users are listed in 'Current users'.

      5. Change maxusersperpage to 100

      6. Go back to "Assign" page and make sure you see "Too many users to show" warning

      Show
      Prerequisite: Site with more than 100 users Log in as admin Update maxusersperpage to something > 100 (Site administration ► Users ► Permissions ► User policies) Test user selector in cohort 1. Create cohort (Site administration ► Users ► Accounts ► Cohorts) 2. Click "Assign" icon (Site administration ► Users ► Accounts ► Cohorts ► Assign) 3. Assign more than 100 users but less than number set for maxusersperpage above 4. Make sure users are listed in 'Current users'. 5. Change maxusersperpage to 100 6. Go back to "Assign" page and make sure you see "Too many users to show" warning
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-44142-master

      Description

      The cohorts assign form 'Current users' list section does not obey the maxusersperpage limit implemented in MDL-36395. Instead it is set to a hard limit of 100.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            dobedobedoh Andrew Nicols added a comment -

            Looks good to me - submitting for integration.

            Thanks Paul

            Show
            dobedobedoh Andrew Nicols added a comment - Looks good to me - submitting for integration. Thanks Paul
            Hide
            cibot CiBoT added a comment -

            Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

            Show
            cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Paul, this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Paul, this has been integrated now.
            Hide
            skodak Petr Skoda added a comment -

            works for me, thanks

            Show
            skodak Petr Skoda added a comment - works for me, thanks
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            I claim to be a simple individual
            liable to err like any other fellow mortal.
            I own, however, that I have humility enough
            to confess my errors and to retrace my steps.

            Mahatma Gandhi

            Your awesome code has met upstream, closing, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - I claim to be a simple individual liable to err like any other fellow mortal. I own, however, that I have humility enough to confess my errors and to retrace my steps. Mahatma Gandhi Your awesome code has met upstream, closing, thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Mar/14