Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44161

Modal Dialogues cause a jump in page position

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.7
    • Component/s: JavaScript, Libraries
    • Labels:
    • Testing Instructions:
      Hide
      • Open login page
      • Scroll down the page a little
      • Click on [?] help icon
        • Confirm the page position doesn't jump to the top
      • Login
      • Open a course
      • Turn editing on
      • Open the activity chooser
        • Confirm the page position doesn't jump to the top
      • Navigate to the Profile Settings page
      • Load the TinyMCE Image plugin and open the filepicker
        • Confirm the page position doesn't jump to the top
      • Chose wikimedia
      • Search for some lolcats
      • Select an image
        • Confirm the page position doesn't jump to the top
      • Close the dialogue
      • Create a new Assignment, submit a PDF to it, and then go to grade it
      • Open EditPDF
        • Confirm the page position doesn't jump to the top
      • Open the Comments Search
        • Confirm the page position doesn't jump to the top
      • Close it
      • Chose the colour dropdown
        • Confirm the page position doesn't jump to the top
      • Navigate to the front page
      • Open the JS console
      • Run the following, and each time a dialogue appears, Confirm the page position doesn't jump to the top:

      d = new M.core.dialogue({});
      // Test
       
      d.destroy();
      d = new M.core.confirm({});
      // Test
       
      d.destroy();
      d = new M.core.ajaxException({});
      // Test
       
      d.destroy();
      d = new M.core.exception({});
      // Test
       
      d.destroy();
      d = new M.core.alert({});
      

      Show
      Open login page Scroll down the page a little Click on [?] help icon Confirm the page position doesn't jump to the top Login Open a course Turn editing on Open the activity chooser Confirm the page position doesn't jump to the top Navigate to the Profile Settings page Load the TinyMCE Image plugin and open the filepicker Confirm the page position doesn't jump to the top Chose wikimedia Search for some lolcats Select an image Confirm the page position doesn't jump to the top Close the dialogue Create a new Assignment, submit a PDF to it, and then go to grade it Open EditPDF Confirm the page position doesn't jump to the top Open the Comments Search Confirm the page position doesn't jump to the top Close it Chose the colour dropdown Confirm the page position doesn't jump to the top Navigate to the front page Open the JS console Run the following, and each time a dialogue appears, Confirm the page position doesn't jump to the top : d = new M.core.dialogue({}); // Test   d.destroy(); d = new M.core.confirm({}); // Test   d.destroy(); d = new M.core.ajaxException({}); // Test   d.destroy(); d = new M.core.exception({}); // Test   d.destroy(); d = new M.core.alert({});
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-44161-master
    • Story Points:
      8
    • Sprint:
      FRONTEND Sprint 9

      Attachments

        Issue Links

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            dobedobedoh Andrew Nicols
            Peer reviewer:
            Damyon Wiese
            Integrator:
            Sam Hemelryk
            Tester:
            Rajesh Taneja
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/May/14