Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44168

remove border=1 from device detection regex table

    Details

    • Testing Instructions:
      Hide

      Visit:

      /moodle/admin/settings.php?section=themesettings

      using Clean theme.

      The table in Device detection regular expressions should look nicer, without ugly black borders on the bottom and vertical dividers.

      Show
      Visit: /moodle/admin/settings.php?section=themesettings using Clean theme. The table in Device detection regular expressions should look nicer, without ugly black borders on the bottom and vertical dividers.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-44168-master

      Description

      There's a border=1 set on the device detection regex table in admin -> theme settings:

      /moodle/admin/settings.php?section=themesettings

      This isn't usually visible because Moodle includes YUI CSS that add a border to every single td and th, and then Moodle CSS fixes that by including CSS that removes borders from every single td and th.

      The Bootstrapbase/Clean theme doesn't use the YUI CSS, and has removed the workaround that removes all borders from tables (in order to fix MDL-27774) and now you get the border=1 on this table showing through again.

      When looking at this I noticed that the code to write out this table has a another bug. Normally the first row has r0 and r1 alternating, while each cell is c0, then c1, then c2 etc. This code adds c0 to each cell on the first row, c1 to each cell on the second row, c2 on each cell on the third row etc.

      I don't know if it's worth messing with, I don't think it has any actual effect, but I thought I'd note it anyway.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Mar/14