Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44170

When preconfigured LTI tools are added to a course, the typeid is not set correctly.

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1. Configure an LTI tool as admin. It doesn't have to be real, just a name and url.
      2. In a course, add an External Tool activity, using the url from step 1. Make sure to use the auto matched type from the dropdown.
      3. SELECT typeid FROM mdl_lti should be the same as SELECT id from mdl_lti_types.

      Show
      1. Configure an LTI tool as admin. It doesn't have to be real, just a name and url. 2. In a course, add an External Tool activity, using the url from step 1. Make sure to use the auto matched type from the dropdown. 3. SELECT typeid FROM mdl_lti should be the same as SELECT id from mdl_lti_types.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-44170-master

      Description

      The typeid column of the mdl_lti table doesn't get set correctly when you add an lti tool to a course. It defaults to 0 every time. This is incorrect behaviour; the typeid should be the same as the id column of mdl_lti_types for the tool in question.

      Steps to reproduce:

      1. Configure an LTI tool as admin. It doesn't have to be real, just a name and url.
      2. In a course, add an External Tool activity, using the url from step 1. Make sure to use the auto matched type from the dropdown.
      3. SELECT * FROM mdl_lti and you'll see the typeid is 0. SELECT * from mdl_lti_types and you'll see the id column of the tool you added in step 1. The typeid of mdl_lti should be the same, but it isn't.

      This causes problems when you need to lookup the permissions of the lti type; it forces you to match on tool url rather than just use the typeid.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                adrian.r.fish@gmail.com Adrian Fish
                Reporter:
                adrian.r.fish@gmail.com Adrian Fish
                Peer reviewer:
                Chris Scribner
                Integrator:
                Damyon Wiese
                Tester:
                Damyon Wiese
                Participants:
                Component watchers:
                Adrian Greeve, Mihail Geshoski, Peter Dias
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/May/14