Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44214

YUI Patching does not support patching of rolled up modules

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      • Make a change to lib/yuilib/3.13.0/widget-modality/widget-modality-min.js (Perhaps add a comment to the first line that you can easily search for)
      • Open lib/setup.php in your editor, and find 'yuipatchlevel'
        • Increment the yuipatchlevel (it's an integer);
        • Add 'widget-modality' to the list of yuipatchedmodules (it's an array)
      • Open your dev tools, refresh a page in moodle, view the networks tab, and open the file first call to yui_combo.php
      • Search for your string
        • Confirm that you found it
      Show
      Make a change to lib/yuilib/3.13.0/widget-modality/widget-modality-min.js (Perhaps add a comment to the first line that you can easily search for) Open lib/setup.php in your editor, and find 'yuipatchlevel' Increment the yuipatchlevel (it's an integer); Add 'widget-modality' to the list of yuipatchedmodules (it's an array) Open your dev tools, refresh a page in moodle, view the networks tab, and open the file first call to yui_combo.php Search for your string Confirm that you found it
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      MDL-44214-master

      Description

      Oops - I forgot to do this bit.
      We can patch non-core stuff, but if anything is in our simpleyui rollup, we cannot patch it.

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            dobedobedoh Andrew Nicols
            Peer reviewer:
            Petr Skoda
            Integrator:
            Damyon Wiese
            Tester:
            Frédéric Massart
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/May/14