Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44273

Back-off strategy for RSS feeds

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.1, 2.8.6, 2.9
    • Fix Version/s: 3.0
    • Component/s: RSS
    • Testing Instructions:
      Hide

      Run the new tests: vendor\bin\phpunit block_rss_client_cron_testcase blocks/rss_client/tests/cron_test.php

      Via the Moodle interface

      Test that the block still displays feeds.

      1. Add an RSS feed block to a Moodle course.
      2. Add at least one RSS feed
      3. Run the moodle cron
      4. Check that messages from the feed now appear in the block in Moodle.

      If you have somewhere you can create RSS feeds and cause them to be unavailable you could do the following test:

      1. Add an RSS feed block to a Moodle course.
      2. Add at least one RSS feed
      3. Run the moodle cron
      4. Check that messages from the feed now appear in the block in Moodle.
      5. Make your feed inaccessible to Moodle
      6. Run cron, verify that the 'Error: could not load/find the RSS feed - skipping for x seconds' message appears for that RSS feed in the cron output
      7. Run cron again within the time: verify that the 'skipping until ' message appears against the feed in the cron output
      8. Make the RSS feed available again.
      9. Run cron after the time seen in step 7, verify that the feed shows as fetched in the cron output
      10. Run cron again and ensure that the feed is fetched.
      Show
      Run the new tests: vendor\bin\phpunit block_rss_client_cron_testcase blocks/rss_client/tests/cron_test.php Via the Moodle interface Test that the block still displays feeds. Add an RSS feed block to a Moodle course. Add at least one RSS feed Run the moodle cron Check that messages from the feed now appear in the block in Moodle. If you have somewhere you can create RSS feeds and cause them to be unavailable you could do the following test: Add an RSS feed block to a Moodle course. Add at least one RSS feed Run the moodle cron Check that messages from the feed now appear in the block in Moodle. Make your feed inaccessible to Moodle Run cron, verify that the 'Error: could not load/find the RSS feed - skipping for x seconds' message appears for that RSS feed in the cron output Run cron again within the time: verify that the 'skipping until ' message appears against the feed in the cron output Make the RSS feed available again. Run cron after the time seen in step 7, verify that the feed shows as fetched in the cron output Run cron again and ensure that the feed is fetched.
    • URL:
    • Affected Branches:
      MOODLE_26_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • Fixed Branches:
      MOODLE_30_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Davo Smith contributed a patch for backing off bad RSS feeds:
      https://moodle.org/mod/forum/discuss.php?d=253717

      This seems like a nice idea to integrate

        Attachments

          Issue Links

          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-57638 block_rss_client does not respect skiptime and skipuntil values

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              • Votes:
                6 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  16/Nov/15