Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44279

Typo in user_get_user_details_courses

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7
    • Fix Version/s: 2.5.5, 2.6.2, 2.7
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      Run the following unit tests as I added new unit tests to trigger this bug.

      vendor/bin/phpunit user/tests/externallib_test.php

      Show
      Run the following unit tests as I added new unit tests to trigger this bug. vendor/bin/phpunit user/tests/externallib_test.php
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull Master Branch:
      44279-27
    • Pull Master Diff URL:

      Description

      There is a rather nasty wee typo in user/lib.php user_get_user_details_courses.

      if ($can_view_user_details_cap($user, $course) || ($user->id == $USER->id) || has_coursecontact_role($user->id)) {
      

      That function has a $ in front of it.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Mar/14