Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44286

Fix Syn library repositioning

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test for regressions

      • Run behat, make sure all passes (check nightly01, you don't need to run it manually)

      Test for this fix (26 and master)

      • This problem is not spotted in all combinations of selenium and firefox and even with these combinations it may not happen, so as long as we don't see the problem we can consider it solved
      • Run behat using:
        • Selenium 2.37
        • Firefox 26 (if possible)
        • The file repository/tests/behat/create_shortcut.feature
          • Something like vendor/bin/behat --config /path/to/behatdataroot/behat/behat.yml /full/path/to/moodle/dirroot/repository/tests/behat/create_shortcut.feature
      • It SHOULD pass

      Only in 2.5

      • Open composer.lock and find "name": "moodlehq/behat-extension"
      • The following line version value SHOULD be v1.25.9
      Show
      Test for regressions Run behat, make sure all passes (check nightly01, you don't need to run it manually) Test for this fix (26 and master) This problem is not spotted in all combinations of selenium and firefox and even with these combinations it may not happen, so as long as we don't see the problem we can consider it solved Run behat using: Selenium 2.37 Firefox 26 (if possible) The file repository/tests/behat/create_shortcut.feature Something like vendor/bin/behat --config /path/to/behatdataroot/behat/behat.yml /full/path/to/moodle/dirroot/repository/tests/behat/create_shortcut.feature It SHOULD pass Only in 2.5 Open composer.lock and find "name": "moodlehq/behat-extension" The following line version value SHOULD be v1.25.9
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-44286_master

      Description

      After a couple of days having fun with behat, modal windows and the locked scroll we have something to punish: Syn library, is the library used by the selenium driver to trigger fake native JS events like onchange; when it is included it checks what features are supported, to do it it focuses on fake elements it creates (and removes after playing with them) and moves the scroll bar, this makes the browser position and focused element to change which is causing problems when we have a locked scroll and may cause other problems that we still don't know.

      Andrew Nicols created an issue in the upstream project (https://github.com/bitovi/syn/issues/30) but the selenium driver for behat is not updating to the last Syn library version so we have to do it in our MoodleSelenium2Driver.

      Here we will only update moodlehq/behat-extension version to a new one, the code changes will be in https://github.com/moodlehq/moodle-behat-extension project.

        Attachments

        1. syn.js
          76 kB
        2. syn.min.js
          30 kB

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Mar/14