Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44287

Warnings in glossary module

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.4, 2.6.1
    • Fix Version/s: 2.5.5, 2.6.2
    • Component/s: Glossary
    • Labels:
    • Testing Instructions:
      Hide
      1. Create glossary with some entries
      2. Export entries
      3. Import entries in a new module, make sure there are no warnings
      4. Try to add/edit/delete categories in glossary, make sure there are no warnings

      Run behat test from MDL-44337

      Show
      Create glossary with some entries Export entries Import entries in a new module, make sure there are no warnings Try to add/edit/delete categories in glossary, make sure there are no warnings Run behat test from MDL-44337
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-44287-master
    • Pull Master Diff URL:
    • Sprint:
      BACKEND Sprint 11

      Description

      While converting logs in MDL-40059 I found some warnings in glossary module:

      1. When importing glossary entries into new glossary:

      Notice: Undefined property: stdClass::$assessed in /home/marina/repositories/master/moodle/mod/glossary/lib.php on line 816
      		 
       
      		 
      Warning: Creating default object from empty value in /home/marina/repositories/master/moodle/mod/glossary/import.php on line 144

      2. When editing/deleting categories there are warnings such as "You should not output before redirecting"

      Fixing those in a separate issue, since it's not related to logging and also may be backported. Also I'm adding a behat test for glossary categories

        Attachments

          Issue Links

          blocks

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-40059 Replace add_to_log with an event trigger - mod_glossary

          • Major - Major loss of function, incorrect output
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-44337 behat test for glossary categories

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              marina Marina Glancy
              Peer reviewer:
              Petr Skoda Petr Skoda
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              Dan Poltawski Dan Poltawski
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Mar/14