[MDL-44287] Warnings in glossary module - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE
Fixed Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Master Branch:
wip-~~MDL-44287~~-master
Pull Master Diff URL:
https://github.com/marinaglancy/moodle/compare/master...wip-MDL-44287-master
Testing Instructions:
Hide

Create glossary with some entries

Export entries

Import entries in a new module, make sure there are no warnings

Try to add/edit/delete categories in glossary, make sure there are no warnings

Run behat test from ~~MDL-44337~~
Show
Create glossary with some entries Export entries Import entries in a new module, make sure there are no warnings Try to add/edit/delete categories in glossary, make sure there are no warnings Run behat test from MDL-44337

While converting logs in ~~MDL-40059~~ I found some warnings in glossary module:

1. When importing glossary entries into new glossary:

Notice: Undefined property: stdClass::$assessed in /home/marina/repositories/master/moodle/mod/glossary/lib.php on line 816

Warning: Creating default object from empty value in /home/marina/repositories/master/moodle/mod/glossary/import.php on line 144

2. When editing/deleting categories there are warnings such as "You should not output before redirecting"

Fixing those in a separate issue, since it's not related to logging and also may be backported. Also I'm adding a behat test for glossary categories

blocks

MDL-40059 Replace add_to_log with an event trigger - mod_glossary

MDL-44337 behat test for glossary categories

Participants:: CiBoT, Dan Poltawski, Eloy Lafuente (stronk7), Marina Glancy, Petr Skoda

Component watchers:: Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie