Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44295

truncate_userinfo is truncating too much.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.1
    • Fix Version/s: 2.7
    • Component/s: Authentication
    • Labels:

      Description

      Since truncate_userinfo was added (2004!) database fields address, institution and department have been increased to allow 255 chars. The code should be updated to reflect this.

        Gliffy Diagrams

          Activity

          Hide
          scyrma Mathieu Petit-Clair added a comment -

          I've sent the diff (updates 3 lines) on github.

          Show
          scyrma Mathieu Petit-Clair added a comment - I've sent the diff (updates 3 lines) on github.
          Hide
          scyrma Mathieu Petit-Clair added a comment -

          Commit sent to github... (I'm a bit lost with the new tracker workflow, please guide me through this!)

          Show
          scyrma Mathieu Petit-Clair added a comment - Commit sent to github... (I'm a bit lost with the new tracker workflow, please guide me through this!)
          Show
          cibot CiBoT added a comment - Results for MDL-44295 Remote repository: https://github.com/scyrma/moodle Remote branch MDL-44295 to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1632 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1632/artifact/work/smurf.html
          Hide
          dobedobedoh Andrew Nicols added a comment -

          Hi Mathieu,

          Thanks for working on this. The patch looks good to me.

          You're nearly there on the new tracker workflow - just missng the diff URL which I've now added.

          [Y] Syntax
          [Y] Whitespace
          [Y] Output
          [-] Language
          [-] Databases
          [Y] Testing (instructions and automated tests)
          [-] Security
          [-] Documentation
          [N] Git
          [-] Third party code
          [Y] Sanity check

          Git:

          We ask that contributors specify the MDL- issue number and the component in the commit message - see http://docs.moodle.org/dev/Coding_style#Git_commits for further information

          Would you be able to rebase on the latest weekly release and produce a patch for MOODLE_26_STABLE too? If not, I can sponsor this the rest of the way.

          Cheers,

          Andrew

          Show
          dobedobedoh Andrew Nicols added a comment - Hi Mathieu, Thanks for working on this. The patch looks good to me. You're nearly there on the new tracker workflow - just missng the diff URL which I've now added. [Y] Syntax [Y] Whitespace [Y] Output [-] Language [-] Databases [Y] Testing (instructions and automated tests) [-] Security [-] Documentation [N] Git [-] Third party code [Y] Sanity check Git: We ask that contributors specify the MDL- issue number and the component in the commit message - see http://docs.moodle.org/dev/Coding_style#Git_commits for further information Would you be able to rebase on the latest weekly release and produce a patch for MOODLE_26_STABLE too? If not, I can sponsor this the rest of the way. Cheers, Andrew
          Hide
          scyrma Mathieu Petit-Clair added a comment -

          Here we go, with the patch applied to 26_STABLE.

          Show
          scyrma Mathieu Petit-Clair added a comment - Here we go, with the patch applied to 26_STABLE.
          Hide
          scyrma Mathieu Petit-Clair added a comment -

          Hi, I'm wondering whether I need to reassign this issue to someone else or if there's anything else that I forgot to do. Should I rebase to the current stable branch every week?

          Show
          scyrma Mathieu Petit-Clair added a comment - Hi, I'm wondering whether I need to reassign this issue to someone else or if there's anything else that I forgot to do. Should I rebase to the current stable branch every week?
          Hide
          jmvedrine Jean-Michel Vedrine added a comment -

          Hello Mathieu,
          You should edit your commit message on each branch as Andrew has asked you "We ask that contributors specify the MDL- issue number and the component in the commit message" and rebase.
          Then put this again in peer review.

          Show
          jmvedrine Jean-Michel Vedrine added a comment - Hello Mathieu, You should edit your commit message on each branch as Andrew has asked you "We ask that contributors specify the MDL- issue number and the component in the commit message" and rebase. Then put this again in peer review.
          Hide
          scyrma Mathieu Petit-Clair added a comment -

          Thanks, done!

          Show
          scyrma Mathieu Petit-Clair added a comment - Thanks, done!
          Show
          cibot CiBoT added a comment - Results for MDL-44295 Remote repository: https://github.com/scyrma/moodle Remote branch MDL-44295 _v26 to be integrated into upstream MOODLE_26_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/2355 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/2355/artifact/work/smurf.html Remote branch MDL-44295 to be integrated into upstream master Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/2356 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/2356/artifact/work/smurf.html
          Hide
          scyrma Mathieu Petit-Clair added a comment -

          Weekly rebase done on github, waiting for peer review.

          Show
          scyrma Mathieu Petit-Clair added a comment - Weekly rebase done on github, waiting for peer review.
          Hide
          poltawski Dan Poltawski added a comment -

          Sending all 'waiting for peer review' issues for integration review. The integration team are doing this to ensure any 'integratable issues' will not got missed for freeze.

          Note: We will prioritise peer reviewed issues and may not spend as much time examining non-integratable, non peer-reviewed issues.

          This is a present from the iTeam - it means that peer review is not working well enough! We really do not want to do this again! Lets improve our peer review process!

          Show
          poltawski Dan Poltawski added a comment - Sending all 'waiting for peer review' issues for integration review. The integration team are doing this to ensure any 'integratable issues' will not got missed for freeze. Note: We will prioritise peer reviewed issues and may not spend as much time examining non-integratable, non peer-reviewed issues. This is a present from the iTeam - it means that peer review is not working well enough! We really do not want to do this again! Lets improve our peer review process!
          Hide
          poltawski Dan Poltawski added a comment -

          I am testing this using the db auth plugin:

          CREATE table danp_users (username TEXT, password TEXT, institution TEXT, department TEXT, address TEXT);
          INSERT INTO danp_users VALUES ('dbtest', 'dbtest1', 'This is a string which will almost get up to 250 characters, if I can possibly make it past here where we are at 100. Keeping going, we are nearly there, getting closer to 250 chars. Finally I have arrived to near 250. Yay and the croud cheered END! ', 'This is a string which will almost get up to 250 characters, if I can possibly make it past here where we are at 100. Keeping going, we are nearly there, getting closer to 250 chars. Finally I have arrived to near 250. Yay and the croud cheered END! ', 'This is a string which will almost get up to 250 characters, if I can possibly make it past here where we are at 100. Keeping going, we are nearly there, getting closer to 250 chars. Finally I have arrived to near 250. Yay and the croud cheered END!')
          

          Show
          poltawski Dan Poltawski added a comment - I am testing this using the db auth plugin: CREATE table danp_users (username TEXT, password TEXT, institution TEXT, department TEXT, address TEXT); INSERT INTO danp_users VALUES ('dbtest', 'dbtest1', 'This is a string which will almost get up to 250 characters, if I can possibly make it past here where we are at 100. Keeping going, we are nearly there, getting closer to 250 chars. Finally I have arrived to near 250. Yay and the croud cheered END! ', 'This is a string which will almost get up to 250 characters, if I can possibly make it past here where we are at 100. Keeping going, we are nearly there, getting closer to 250 chars. Finally I have arrived to near 250. Yay and the croud cheered END! ', 'This is a string which will almost get up to 250 characters, if I can possibly make it past here where we are at 100. Keeping going, we are nearly there, getting closer to 250 chars. Finally I have arrived to near 250. Yay and the croud cheered END!')
          Hide
          poltawski Dan Poltawski added a comment -

          Thanks Mathieu, long time no see!

          Integrated to master and 26 (noted that the limits were changed in 26)

          Show
          poltawski Dan Poltawski added a comment - Thanks Mathieu, long time no see! Integrated to master and 26 (noted that the limits were changed in 26)
          Hide
          poltawski Dan Poltawski added a comment -

          Tested on master and 26

          Show
          poltawski Dan Poltawski added a comment - Tested on master and 26
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Closing this as fixed, now it's part of Moodle upstream! Thanks!

          And in the end,
          it's not the years in your life that count,
          it's the life in your years.

          ~ Abraham Lincoln ~

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Closing this as fixed, now it's part of Moodle upstream! Thanks! And in the end, it's not the years in your life that count, it's the life in your years. ~ Abraham Lincoln ~

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14