[MDL-44333] Quiz overview report typo for slotmarks user preference - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

To test this, you need two different Moodle quizzes, with some student attempts.

Go to Admin -> Results in one quiz.

Change the 'Marks for each question' setting in that quiz to No.

Go back to the course page.

Go to the other quiz.

Go to Admin -> Results for that quiz.

Verify that in that other quiz, 'Marks for each question' setting in that quiz also set to No.

(So, we are testing that the state of that setting is correctly stored as a user-preference.)
Show
To test this, you need two different Moodle quizzes, with some student attempts. Go to Admin -> Results in one quiz. Change the 'Marks for each question' setting in that quiz to No. Go back to the course page. Go to the other quiz. Go to Admin -> Results for that quiz. Verify that in that other quiz, 'Marks for each question' setting in that quiz also set to No. (So, we are testing that the state of that setting is correctly stored as a user-preference.)
Affected Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE
Fixed Branches:
MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-44333~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-44333

In the quiz overview report

public function setup_from_user_preferences() {

        parent::setup_from_user_preferences();

        $this->slotmarks = get_user_preferences('quiz_report_overview_detailedmarks', $this->slotmarks);

    public function update_user_preferences() {

        parent::update_user_preferences();

        if (quiz_has_grades($this->quiz)) {

            set_user_preference('quiz_overview_slotmarks', $this->slotmarks);

You see, the name used to store and load user preference are not the same.

has a non-specific relationship to

MDL-43833 Quiz reports lose settings

Participants:: CiBoT, Eloy Lafuente (stronk7), Gareth J Barnard, Jean-Michel Vedrine, John Okely, Marina Glancy, Tim Hunt

Component watchers:: Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze