Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44334

Disable dialogue scroll locking for small windows (height)

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6.3
    • Component/s: JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      On a normal sized screen:

      • Open the following dialogues and confirm that the scroll lock is active:
        • Activity chooser
        • File picker
        • A confirmation box (e.g. delete activity)
      • Make your window height much smaller so that it is smaller than the dialogues (this probably won't be possible with the confirmation), but keep the width normal
      • Repeat, confirming that the scroll lock was not enabled
      • Make your window width smaller too
      • Repeat confirming that the dialogues were shown full screen
      • Confirm that the when you scroll and then close the dialogue, the background window has not changed.

      Note: In testing this, I discovered that iOS does not handle the scroll locking in the same way - it completely ignores the body overflow property.

      • Test edit pdf in different screen sizes and verify you can always get to the submit buttons at the bottom of the dialogue.
      Show
      On a normal sized screen: Open the following dialogues and confirm that the scroll lock is active: Activity chooser File picker A confirmation box (e.g. delete activity) Make your window height much smaller so that it is smaller than the dialogues (this probably won't be possible with the confirmation), but keep the width normal Repeat, confirming that the scroll lock was not enabled Make your window width smaller too Repeat confirming that the dialogues were shown full screen Confirm that the when you scroll and then close the dialogue, the background window has not changed. Note: In testing this, I discovered that iOS does not handle the scroll locking in the same way - it completely ignores the body overflow property. Test edit pdf in different screen sizes and verify you can always get to the submit buttons at the bottom of the dialogue.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-44334-master

      Description

      As pointed out by [~davmon], if a user has a small (vertical) window, then they will not be able to access all parts of a dialogue.

      At the same time however, we should enable the scroll lock for our full screen dialogues to prevent the background window from moving when the user scrolls.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                2 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/May/14