Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44354

The target parameter is ignored when getting the renderer

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6
    • Fix Version/s: 2.6.3
    • Component/s: Themes
    • Labels:
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      44354-27
    • Pull Master Diff URL:
    • Testing Instructions:
      Hide
      1. Download the attached 44354-test.php script and drop it into your Moodle dirroot.
      2. Browse to it and check that you get a big green success message.

      If you get red instead I've failed again.

      Show
      Download the attached 44354-test.php script and drop it into your Moodle dirroot. Browse to it and check that you get a big green success message. If you get red instead I've failed again.

      Description

      In moodle_page->get_renderer() the $target parameter is ignored because the first line in the function sets $target to null. This seems to be unintentional as I don't know why this ability should be removed.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              samhemelryk Sam Hemelryk
              Reporter:
              bushido Mark Nielsen
              Peer reviewer:
              Frédéric Massart Frédéric Massart
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              Ankit Agarwal Ankit Agarwal
              Participants:
              Component watchers:
              Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/May/14