Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44366

filter_glossary has the potential to be slow on large sites

    XMLWordPrintable

Details

    • MOODLE_26_STABLE
    • MOODLE_27_STABLE
    • w16_MDL-44366_m27_filtergloss
    • Hide

      1/ execute phpunit tests
      2/ set up glossary linking (enable in glossary and entries, add categories and aliases, enable filter) and test if it works as before or better (now it should deal with groupmembersonly too)
      3/ verify that enabling of the glossary filter does not increase DB queries per page
      4/ create a number of glossaries in different courses with additional entries
      5/ verify that the number of DB queries does not increase

      Show
      1/ execute phpunit tests 2/ set up glossary linking (enable in glossary and entries, add categories and aliases, enable filter) and test if it works as before or better (now it should deal with groupmembersonly too) 3/ verify that enabling of the glossary filter does not increase DB queries per page 4/ create a number of glossaries in different courses with additional entries 5/ verify that the number of DB queries does not increase
    • 40
    • BACKEND Sprint 12

    Description

      As a follow-on to MDL-43524 which removed global text caching, we need to examine the glossary filter and probably add MUC caching there to improve performance.

      The glossary filter is what puts links in texts to glossary entries. There is quite a lot of processing going on in the background even before the simple text replacement, and this needs to be redone every time the cache is invalidated.

      Petr has raised that the fully correct way would be to use new events or the as-yet-unwritten hooks to invalidate the caches, but I think that might be too much to do before 2.7, so I want to see a quick solution here even if it may mean relying on less-perfect cache invalidation.

      This issue requires performance comparison tests before and after the fix.

      Attachments

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-23810 Glossary autolink wrong display for uploaded HTML files

          • Major - Major loss of function, incorrect output
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-43524 Drop problematic global text caching

          • Major - Major loss of function, incorrect output
          • Closed
          has been marked as being related by

          Improvement - An enhancement to an existing Moodle feature. MDL-47962 Major room for performance improvement in filter_glossary

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          is duplicated by

          Improvement - An enhancement to an existing Moodle feature. MDL-43014 Course with LABEL activities - excessive load times

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              skodak Petr Skoda
              dougiamas Martin Dougiamas
              Marina Glancy Marina Glancy
              Dan Poltawski Dan Poltawski
              Adrian Greeve Adrian Greeve
              Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie, Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/May/14