Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44370

Incorrect urls for calendar logs in log and loglive reports

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.1
    • Fix Version/s: 2.5.5, 2.6.2
    • Component/s: Reports
    • Labels:
    • Testing Instructions:
      Hide
      1. Create/edit events in calendar.
      2. Goto reports (log and loglive) and valid that "action" field for those actions, link to a page where you can edit the event.
      3. Backup and restore a course with calendar related logs. (make sure you check logs during backup). Calendar logs should be restored properly.
      Show
      Create/edit events in calendar. Goto reports (log and loglive) and valid that "action" field for those actions, link to a page where you can edit the event. Backup and restore a course with calendar related logs. (make sure you check logs during backup). Calendar logs should be restored properly.
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      MDL-44370-master
    • Sprint:
      BACKEND Sprint 11
    • Story Points (Obsolete):
      3
    • Sprint:
      BACKEND Sprint 11

      Description

      Calendar actions such as adding and editing events generate logs. The logs link to the page in the format course/event.php?action=edit&id=12931 in reports.
      This link generats a 404 error as the specified path does not exist.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            ankit_frenz Ankit Agarwal added a comment -

            This issue blocks proper testing of MDL-40915

            Show
            ankit_frenz Ankit Agarwal added a comment - This issue blocks proper testing of MDL-40915
            Hide
            cibot CiBoT added a comment -

            Results for MDL-44370

            • Remote repository: git://github.com/ankitagarwal/moodle.git
            Show
            cibot CiBoT added a comment - Results for MDL-44370 Remote repository: git://github.com/ankitagarwal/moodle.git Remote branch MDL-44370 -24 to be integrated into upstream MOODLE_24_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1767 Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1767/artifact/work/smurf.html Remote branch MDL-44370 -25 to be integrated into upstream MOODLE_25_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1768 Warning: The MDL-44370 -25 branch at git://github.com/ankitagarwal/moodle.git has not been rebased recently (>20 days ago). Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1768/artifact/work/smurf.html Remote branch MDL-44370 -26 to be integrated into upstream MOODLE_26_STABLE Executed job http://integration.moodle.org/job/Precheck%20remote%20branch/1769 Warning: The MDL-44370 -26 branch at git://github.com/ankitagarwal/moodle.git has not been rebased recently (>20 days ago). Details: http://integration.moodle.org/job/Precheck%20remote%20branch/1769/artifact/work/smurf.html
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks for fixing this Ankit,

            Patch looks spot-on, pushing for integration review.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks for fixing this Ankit, Patch looks spot-on, pushing for integration review.
            Hide
            cibot CiBoT added a comment -

            Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

            Show
            cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
            Hide
            damyon Damyon Wiese added a comment -

            Stealing from Dan, cause I already looked at the branch but tracker failed to start the review for me.

            Show
            damyon Damyon Wiese added a comment - Stealing from Dan, cause I already looked at the branch but tracker failed to start the review for me.
            Hide
            damyon Damyon Wiese added a comment -

            Thanks Ankit,

            It's good that the events changes are highlighting existing bugs that have been sitting there unnoticed.

            Thanks for fixing this - but this is missing a restore_log_rule for the '/calendar/' urls.

            There is a TODO in "backup/moodle2/restore_final_task.class.php" that marks where to put it...

            Also can we have a master branch and no 24 branch please (it wont' be integrated there)?

            Cheers, Damyon

            Show
            damyon Damyon Wiese added a comment - Thanks Ankit, It's good that the events changes are highlighting existing bugs that have been sitting there unnoticed. Thanks for fixing this - but this is missing a restore_log_rule for the '/calendar/' urls. There is a TODO in "backup/moodle2/restore_final_task.class.php" that marks where to put it... Also can we have a master branch and no 24 branch please (it wont' be integrated there)? Cheers, Damyon
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Hi Damyon,
            I don't see how adding support for restoring calendar logs has anything to do with this issue. This issue is only about fixing broken urls in Reports. Anyway, I have added a commit to support calendar log restore.

            Pushing back.

            Cheers

            Show
            ankit_frenz Ankit Agarwal added a comment - Hi Damyon, I don't see how adding support for restoring calendar logs has anything to do with this issue. This issue is only about fixing broken urls in Reports. Anyway, I have added a commit to support calendar log restore. Pushing back. Cheers
            Hide
            damyon Damyon Wiese added a comment -

            Integrated to 25, 26 and master.

            It is disappointing that you didn't bother fixing the obviously missing log for deleting an event in this issue. What is the point of improving all this logging if you do not do a complete job?

            Show
            damyon Damyon Wiese added a comment - Integrated to 25, 26 and master. It is disappointing that you didn't bother fixing the obviously missing log for deleting an event in this issue. What is the point of improving all this logging if you do not do a complete job?
            Hide
            damyon Damyon Wiese added a comment -

            Tested in integration.

            Show
            damyon Damyon Wiese added a comment - Tested in integration.
            Hide
            damyon Damyon Wiese added a comment -

            Works as described (and nothing more...)

            Passing.

            Show
            damyon Damyon Wiese added a comment - Works as described (and nothing more...) Passing.
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            You wanted to add new events, in this issue?

            Show
            ankit_frenz Ankit Agarwal added a comment - You wanted to add new events, in this issue?
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            For fun: http://www.youtube.com/watch?v=IGENkpaPkgw

            Many thanks for your hard work, this is now part of Moodle!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - For fun: http://www.youtube.com/watch?v=IGENkpaPkgw Many thanks for your hard work, this is now part of Moodle! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Mar/14

                  Agile