Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44434

Update syn.js added by MDL-44286

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Test for regressions

      • Run behat, make sure all passes (check nightly01, you don't need to run it manually)

      Test for this fix (26 and master)

      • This problem is not spotted in all combinations of selenium and firefox and even with these combinations it may not happen, so as long as we don't see the problem we can consider it solved
      • Run behat using:
        • Selenium 2.37
        • Firefox 26 (if possible)
        • The file repository/tests/behat/create_shortcut.feature
          • Something like vendor/bin/behat --config /path/to/behatdataroot/behat/behat.yml /full/path/to/moodle/dirroot/repository/tests/behat/create_shortcut.feature
      • It SHOULD pass
      • Test with phantomjs if possible.

      Only in 2.5

      • Open composer.lock and find "name": "moodlehq/behat-extension"
      • The following line version value SHOULD be v1.25.9
      Show
      Test for regressions Run behat, make sure all passes (check nightly01, you don't need to run it manually) Test for this fix (26 and master) This problem is not spotted in all combinations of selenium and firefox and even with these combinations it may not happen, so as long as we don't see the problem we can consider it solved Run behat using: Selenium 2.37 Firefox 26 (if possible) The file repository/tests/behat/create_shortcut.feature Something like vendor/bin/behat --config /path/to/behatdataroot/behat/behat.yml /full/path/to/moodle/dirroot/repository/tests/behat/create_shortcut.feature It SHOULD pass Test with phantomjs if possible. Only in 2.5 Open composer.lock and find "name": "moodlehq/behat-extension" The following line version value SHOULD be v1.25.9
    • Affected Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • Pull Master Branch:
      wip-mdl-44434

      Description

      Syn library has been released with window repositioning fix https://github.com/bitovi/syn/pull/30

      It would be nice to revert syn.js introduced by MDL-44286 and use original copy of syn.js

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: