Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44440

Make behat work with clean as default

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Probably would be good that 2 people shares this test, it is not time consuming but the suite takes a lot of time to finish.

      1. Add $CFG->theme = 'clean'; in config.php
      2. Run the whole behat suite
      3. It SHOULD all pass
      4. Run the whole behat suite using --tags @javascript, and, once the browser window is opened, resize it to a medium window size so the usual 'Log in' link is hidden behind the nav-bar button (top right)
      5. It SHOULD all pass
      Show
      Probably would be good that 2 people shares this test, it is not time consuming but the suite takes a lot of time to finish. Add $CFG->theme = 'clean'; in config.php Run the whole behat suite It SHOULD all pass Run the whole behat suite using --tags @javascript, and, once the browser window is opened, resize it to a medium window size so the usual 'Log in' link is hidden behind the nav-bar button (top right) It SHOULD all pass
    • Affected Branches:
      MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-44440_master

      Description

      I closed MDL-44035 as MDL-43838 duplicate and I shouldn't as there are other things that needs to be fixed.

      As MDL-43839 was reopened I create a separate issue and mark it as a blocker.

      All the work is already done: https://tracker.moodle.org/browse/MDL-43839?focusedCommentId=273120&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-273120

      Would be also good to include these changes in 2.6 in case 3rd parties have themes extending clean.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dmonllao David Monllaó
              Reporter:
              dmonllao David Monllaó
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              Dan Poltawski
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Mar/14