Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-43786 "More" - a new theme like Clean but with more customisation settings in the UI
  3. MDL-44453

Improve LESS performance whenever themedesignermode is enabled

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Won't Fix
    • Icon: Major Major
    • None
    • 2.7
    • Themes
    • MOODLE_27_STABLE
    • MDL-44453-master
    • Hide
      1. Use clean, and set theme designer mode to enabled
      2. Set define('THEME_DESIGNER_CACHE_LIFETIME', 1); in your config file
      3. Purge the cache (via CLI)
      4. Load a page, and observe that the styles are loaded slowly in styles_debug.php.
      5. Now reload the page, and make sure the styles are loaded fast, repeat several times
      6. One at a time, make some changes to one of the following, and make sure the styles are recompiled, and after one compile it loads quickly
        • CSS file in a plugin
        • Theme CSS file
        • Theme LESS file
      Show
      Use clean, and set theme designer mode to enabled Set define('THEME_DESIGNER_CACHE_LIFETIME', 1); in your config file Purge the cache (via CLI) Load a page, and observe that the styles are loaded slowly in styles_debug.php. Now reload the page, and make sure the styles are loaded fast, repeat several times One at a time, make some changes to one of the following, and make sure the styles are recompiled, and after one compile it loads quickly CSS file in a plugin Theme CSS file Theme LESS file
    • FRONTEND Sprint 11

      When themedesignermode is enabled and the theme is using a LESS file, the compilation takes a very long time (about 10s). We should try to set up some cache to only compile whenever necessary.

      Ways to solve that:

      • Look into the caching built-in less.php
      • Extend less.php to implement our own caching
      • Hash the CSS/LESS files and the dynamic content (callbacks) and check if it has changed, if not return the previous result.
      • ...

      PS: I lost the issue I thought I had raised, so re-raising this.

            fred Frédéric Massart
            fred Frédéric Massart
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.