Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44482

LTI date created displaying erroneously for non-English languages

    XMLWordPrintable

Details

    • MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • MDL-44482-master
    • Hide
      1. Install the following language packs: ja, he, th
      2. With your language set to English, navigate to Site administration -> Plugins -> Activity modules -> LTI
      3. Click Add external tool configuration.
      4. Set Tool Name to external tool, and Tool Base URL to https://spmoodle.science.co.jp/local/ltiprovider/tool.php?id=2, then click Save changes.
        • Observe that a new entry in the LTI table has been created, and that the Created On value is accurate.
      5. Change to each of the language packs you have installed, each time verifying that the Created On value is accurate and of appropriate format for each language.
      Show
      Install the following language packs: ja , he , th With your language set to English, navigate to Site administration -> Plugins -> Activity modules -> LTI Click Add external tool configuration . Set Tool Name to external tool , and Tool Base URL to https://spmoodle.science.co.jp/local/ltiprovider/tool.php?id=2 , then click Save changes . Observe that a new entry in the LTI table has been created, and that the Created On value is accurate. Change to each of the language packs you have installed, each time verifying that the Created On value is accurate and of appropriate format for each language.

    Description

      When using a variety of non-English languages (e.g. Japanese, Thai, Hebrew), the date created field in the LTI table erroneously displays NaN/NaN/NaN.

      This is caused by a userdate() call that doesn't specify the appropriate date format string as the second parameter in mod/lti/locallib.php.

      Attachments

        Issue Links

          Activity

            People

              jethac Jetha Chan
              h-honda Hiroshi Honda
              Andrew Lyons Andrew Lyons
              Marina Glancy Marina Glancy
              Adrian Greeve Adrian Greeve
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/Jul/14