Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44507

Filemanager download all indicator and repeated click supression

    Details

    • Testing Instructions:
      Hide

      Create a folder resource in a course.
      Add several files to the folder resource.
      Save and display it.
      Edit the folder resource.
      Click the "Download All" button.
      A waiting icon will appear next to the button indicating the download is getting ready.
      Additional clicks of "Download All" should not create additional AJAX download requests.
      When the file download begins the waiting icon will disappear.

      Show
      Create a folder resource in a course. Add several files to the folder resource. Save and display it. Edit the folder resource. Click the "Download All" button. A waiting icon will appear next to the button indicating the download is getting ready. Additional clicks of "Download All" should not create additional AJAX download requests. When the file download begins the waiting icon will disappear.
    • Affected Branches:
      MOODLE_27_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-44507_master

      Description

      When there is a large amount files the filemanager can take a while to create the zip file when "download all" is clicked. Since it uses an AJAX request to get the file the user sees no indicator that anything is happening. If they click "download all" repeatedly the server performance can drop severely.

      The improvement is to display a loading icon next to the download all button when it is clicked and hide the icon once the download has started. While the loading icon is visible the download all button is essentially disabled.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/May/14