Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44538

corner styles on block pop-up menu wrong

XMLWordPrintable

    • MOODLE_26_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
    • MOODLE_34_STABLE, MOODLE_35_STABLE
    • MDL-44538-master
    • Hide
      1. test in clean.
      2. create a course.
      3. turn editing on.
      4. add a lastest announcements block.
      5. click the actions cog on the latest announcements block.
      6. scroll throught the options in the pop up menu.
      7. cross check only the first entry has rounded edges at the top corners and the latest entry has rounded edges at the bottom corners.

      Show
      test in clean. create a course. turn editing on. add a lastest announcements block. click the actions cog on the latest announcements block. scroll throught the options in the pop up menu. cross check only the first entry has rounded edges at the top corners and the latest entry has rounded edges at the bottom corners.

      This is regarding the new(-ish) menu that pops up on blocks to let you configure/hide etc. it.

      One of the styles, intended to give rounded corners on the top of the first item and the bottom of the last item of the list is wrong, and instead puts rounded corners on each item by mistake.

      The lines are here:

      https://github.com/moodle/moodle/blob/master/theme/bootstrapbase/less/moodle/core.less#L2138-L2143

      That's saying round the top of the first "a" tag in any div in the menu, but actually it should say round the top of the (only) "a" tag in the first li and so on, so we want "li:firstchild a" instead.

        1. image-2018-08-01-08-29-01-899.png
          126 kB
          Janelle Barcega
        2. MDL-44538-after.png
          63 kB
          Luca Bösch
        3. MDL-44538-before.png
          90 kB
          Luca Bösch

            lucaboesch Luca Bösch
            bawjaws David Scotson
            Bas Brands Bas Brands
            David Monllaó David Monllaó
            Janelle Barcega Janelle Barcega
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 36 minutes
                36m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.