Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-44548

SCORM Repository Auto Update Non-functional

    Details

      Description

      SCORM modules added from file system repo are not updating when file/s replaced in repo.

      Instructions were followed from:
      http://danmarsden.com/blog/2013/09/24/managing-scorm-content-in-moodle-2-6/

      Essentially:

      1. Save zipped SCORM object to file system repository directory that you have created under moodledata folder
      2. Create new activity in Moodle, selecting SCORM package.
      3. Use file picker to choose SCORM object from file system repository you set up (make sure to select Create an Alias / Shortcut and assign Auto-Update to Every Time It's Used or Daily)
      4. Go through lesson/quiz to completion.
      5. Make change to SCORM object and save updated file in repository directory (renaming or deleting old file).
      6. Enter lesson again to check if update occurred (or after cron job run if Daily selected).

      Current result is no change to the SCORM object when accessed either minutes later, hours later or after cron job.

      Appears file is either a) not being checked properly for difference - although it does appear to be based on code or b) is being checked for difference but still not parsing this information correctly and retrieving the updated file.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              danmarsden Dan Marsden added a comment -

              thanks for the report - I'm pretty busy at the moment but will try to look at this when I find some time!

              Show
              danmarsden Dan Marsden added a comment - thanks for the report - I'm pretty busy at the moment but will try to look at this when I find some time!
              Hide
              pnbowen@gmail.com Peter Bowen added a comment -

              I suspect the issue is with the browser cache, and it affects all repository files.

              My testing was as follows:

              Copy a SCORM Zip to the file system repository
              Create a new SCORM pointing to the file system repository as an alias, updated every time it is used
              Open the SCORM in Firefox - works OK
              Replaced the SCORM Zip in the file system with a different SCORM, but the same name
              Opened the SCORM in Firefox - still shows the old SCORM
              Opened the SCORM in IE, it shows the new SCORM
              Clear the browser cache on Firefox
              Open the SCORM in Firefox - shows the new SCORM

              I tried the above with pdf files as well - same results. If I clear the browser cache, it updates OK.

              I guess the next questions is - can we set something server side to prevent the browsers from caching SCORM files?

              Show
              pnbowen@gmail.com Peter Bowen added a comment - I suspect the issue is with the browser cache, and it affects all repository files. My testing was as follows: Copy a SCORM Zip to the file system repository Create a new SCORM pointing to the file system repository as an alias, updated every time it is used Open the SCORM in Firefox - works OK Replaced the SCORM Zip in the file system with a different SCORM, but the same name Opened the SCORM in Firefox - still shows the old SCORM Opened the SCORM in IE, it shows the new SCORM Clear the browser cache on Firefox Open the SCORM in Firefox - shows the new SCORM I tried the above with pdf files as well - same results. If I clear the browser cache, it updates OK. I guess the next questions is - can we set something server side to prevent the browsers from caching SCORM files?
              Hide
              scott_wyatt Scott Wyatt added a comment -

              Unfortunately I haven't had your success, Peter.

              The issue has persisted across Chome and IE even after wiping browser cache and histories. I think you've hit the nail on the head though - a serverside setting to prevent browsers from storing SCORM packages in cache (specifically when they're set to the Auto Update setting), would be helpful.

              Show
              scott_wyatt Scott Wyatt added a comment - Unfortunately I haven't had your success, Peter. The issue has persisted across Chome and IE even after wiping browser cache and histories. I think you've hit the nail on the head though - a serverside setting to prevent browsers from storing SCORM packages in cache (specifically when they're set to the Auto Update setting), would be helpful.
              Hide
              danmarsden Dan Marsden added a comment -

              yeah - definitely something to think about here - Scott there are various locations that might be causing the caching of the content - some sites sit behind caching servers (Moodle.org sits behind cloudflare which does some caching afaik) - also some ISPs also cache the content.

              There is a site-wide global function that will set the lifetime of a file which is used in this case ($CFG->filelifetime) - that is set to 6hrs by default which seems enough to me for most purposes - Scott it would be interesting to hear if you left it overnight and tried it again to see if it was updated the day after?

              We could force all files stored in the repo to not be cached at all but I really don't like that option much myself - seems like it would cause unnecessary load on the server. We need to think about this a bit.

              Show
              danmarsden Dan Marsden added a comment - yeah - definitely something to think about here - Scott there are various locations that might be causing the caching of the content - some sites sit behind caching servers (Moodle.org sits behind cloudflare which does some caching afaik) - also some ISPs also cache the content. There is a site-wide global function that will set the lifetime of a file which is used in this case ($CFG->filelifetime) - that is set to 6hrs by default which seems enough to me for most purposes - Scott it would be interesting to hear if you left it overnight and tried it again to see if it was updated the day after? We could force all files stored in the repo to not be cached at all but I really don't like that option much myself - seems like it would cause unnecessary load on the server. We need to think about this a bit.
              Hide
              pnbowen@gmail.com Peter Bowen added a comment - - edited

              Ah - lightbulb moment there... Except....

              I redid the testing today, and I am now not getting the SCORM files updating. I am now second guessing my testing yesterday.

              I was using pdf's yesterday as well, and found they were not updating. Changing the lifetime setting, then yes, the pdf's now operate as expected.
              However the SCORMS are still not. (zip files)

              Using just a manifest file pulls an interesting result - it appears that it is still trying to use the old manifest.xml, however the files that are being referenced are no longer there. It produces the error:

              An error has occured:
              Error - unable to acquire LMS API, content may not play properly and results may not be recorded. Please contact technical support.
              Press 'OK' to view debug information to send to technical support.

              So sorry Dan, I am now agreeing with Scott on the SCORM results.

              Show
              pnbowen@gmail.com Peter Bowen added a comment - - edited Ah - lightbulb moment there... Except.... I redid the testing today, and I am now not getting the SCORM files updating. I am now second guessing my testing yesterday. I was using pdf's yesterday as well, and found they were not updating. Changing the lifetime setting, then yes, the pdf's now operate as expected. However the SCORMS are still not. (zip files) Using just a manifest file pulls an interesting result - it appears that it is still trying to use the old manifest.xml, however the files that are being referenced are no longer there. It produces the error: An error has occured: Error - unable to acquire LMS API, content may not play properly and results may not be recorded. Please contact technical support. Press 'OK' to view debug information to send to technical support. So sorry Dan, I am now agreeing with Scott on the SCORM results.
              Hide
              scott_wyatt Scott Wyatt added a comment -

              Dan, very good point there - I'll investigate further with our IT department what the caching points are (though we are running Moodle on our own server, I believe I'm accessing it through our Azure provider).

              In an odd twist of events, a module that I'd uploaded a new SCORM zip for but was still showing me old versions here in the office was reported by a student to now be correct (indicating they were having the new module loaded at their end)... further supporting the idea that it is a caching issue...

              Maybe we should look at a separate file lifetime function for repositories (which can be set at a repo level depending on the likelihood of updates... eg, I would set it to hourly for the first week or two of a semester and then back to 6 hours afterwards). This would avoid server loads increasing on the overall site and would allow rapid updates when need be. But maybe that defeats the purpose of the auto-update function then...

              Show
              scott_wyatt Scott Wyatt added a comment - Dan, very good point there - I'll investigate further with our IT department what the caching points are (though we are running Moodle on our own server, I believe I'm accessing it through our Azure provider). In an odd twist of events, a module that I'd uploaded a new SCORM zip for but was still showing me old versions here in the office was reported by a student to now be correct (indicating they were having the new module loaded at their end)... further supporting the idea that it is a caching issue... Maybe we should look at a separate file lifetime function for repositories (which can be set at a repo level depending on the likelihood of updates... eg, I would set it to hourly for the first week or two of a semester and then back to 6 hours afterwards). This would avoid server loads increasing on the overall site and would allow rapid updates when need be. But maybe that defeats the purpose of the auto-update function then...
              Hide
              andrecruzmendes André Cruz Mendes added a comment - - edited

              Dan, I think the problem is the "contenthash" of the files.
              The FileStorage gets the old file's content (and extracts it) because the new contenthash is still the same.
              It needs to be synced.

              I'm using the filesystem repository to storage the scorm packages.
              Then, I make some changes in two php files:

              • repository/filesystem/lib.php
                • because the function "sync_reference()" was syncing just image files;
              • mod/scorm/locallib.php
                • before "$packagefile->import_external_file_contents();" need to call "$packagefile->sync_external_file();"
                • and remove the conditions like "$scorm->scormtype != SCORM_TYPE_LOCAL" to call scorm_parse($scorm, false);

              It works for me (I'm using Moodle 2.7).

              Hope this helps.

              Show
              andrecruzmendes André Cruz Mendes added a comment - - edited Dan, I think the problem is the "contenthash" of the files. The FileStorage gets the old file's content (and extracts it) because the new contenthash is still the same. It needs to be synced. I'm using the filesystem repository to storage the scorm packages. Then, I make some changes in two php files: repository/filesystem/lib.php because the function "sync_reference()" was syncing just image files; mod/scorm/locallib.php before "$packagefile->import_external_file_contents();" need to call "$packagefile->sync_external_file();" and remove the conditions like "$scorm->scormtype != SCORM_TYPE_LOCAL" to call scorm_parse($scorm, false); It works for me (I'm using Moodle 2.7). The file's changes can be download for now from: https://dl.dropboxusercontent.com/u/6407866/moodle-scorm-sync-changes.zip Hope this helps.
              Hide
              pnbowen Peter Bowen added a comment -

              Hi Andre,

              I grabbed the changes and put it in our test system - v2.6.2+, and it works a treat. More than happy with this!

              Cheers
              Peter

              Show
              pnbowen Peter Bowen added a comment - Hi Andre, I grabbed the changes and put it in our test system - v2.6.2+, and it works a treat. More than happy with this! Cheers Peter
              Hide
              danmarsden Dan Marsden added a comment -

              Thanks Andre, we'll try to take a look at this soon!

              Show
              danmarsden Dan Marsden added a comment - Thanks Andre, we'll try to take a look at this soon!
              Hide
              andrecruzmendes André Cruz Mendes added a comment -

              You are welcome! =D
              Just be careful with the changes, because I do not know yet if there are another implications.

              Show
              andrecruzmendes André Cruz Mendes added a comment - You are welcome! =D Just be careful with the changes, because I do not know yet if there are another implications.
              Hide
              danmarsden Dan Marsden added a comment -

              Hi André,

              Thanks for the detailed analysis - from what I can see I think all we need is to add the call to sync_external_file like the patch I've attached here - but I haven't tested this to see if it works as expected yet.

              Show
              danmarsden Dan Marsden added a comment - Hi André, Thanks for the detailed analysis - from what I can see I think all we need is to add the call to sync_external_file like the patch I've attached here - but I haven't tested this to see if it works as expected yet.
              Hide
              matteo Matteo Scaramuccia added a comment -

              Hi Dan,
              not had the time to run anything yet (back from holidays) but I guess that this should be included too (from André Cruz Mendes comments):

              $ git diff
              diff --git a/mod/scorm/locallib.php b/mod/scorm/locallib.php
              index 189a2e2..97faa17 100644
              --- a/mod/scorm/locallib.php
              +++ b/mod/scorm/locallib.php
              @@ -844,7 +844,7 @@ function scorm_get_all_attempts($scormid, $userid) {
               function scorm_view_display ($user, $scorm, $action, $cm) {
                   global $CFG, $DB, $PAGE, $OUTPUT, $COURSE;
               
              -    if ($scorm->scormtype != SCORM_TYPE_LOCAL && $scorm->updatefreq == SCORM_UPDATE_EVERYTIME) {
              +    if ($scorm->updatefreq == SCORM_UPDATE_EVERYTIME) {
                       scorm_parse($scorm, false);
                   }
               
              @@ -946,7 +946,7 @@ function scorm_simple_play($scorm, $user, $context, $cmid) {
                       return $result;
                   }
               
              -    if ($scorm->scormtype != SCORM_TYPE_LOCAL && $scorm->updatefreq == SCORM_UPDATE_EVERYTIME) {
              +    if ($scorm->updatefreq == SCORM_UPDATE_EVERYTIME) {
                       scorm_parse($scorm, false);
                   }
                   $scoes = $DB->get_records_select('scorm_scoes', 'scorm = ? AND '.
              

              Show
              matteo Matteo Scaramuccia added a comment - Hi Dan, not had the time to run anything yet (back from holidays) but I guess that this should be included too (from André Cruz Mendes comments): $ git diff diff --git a/mod/scorm/locallib.php b/mod/scorm/locallib.php index 189a2e2..97faa17 100644 --- a/mod/scorm/locallib.php +++ b/mod/scorm/locallib.php @@ -844,7 +844,7 @@ function scorm_get_all_attempts($scormid, $userid) { function scorm_view_display ($user, $scorm, $action, $cm) { global $CFG, $DB, $PAGE, $OUTPUT, $COURSE;   - if ($scorm->scormtype != SCORM_TYPE_LOCAL && $scorm->updatefreq == SCORM_UPDATE_EVERYTIME) { + if ($scorm->updatefreq == SCORM_UPDATE_EVERYTIME) { scorm_parse($scorm, false); }   @@ -946,7 +946,7 @@ function scorm_simple_play($scorm, $user, $context, $cmid) { return $result; }   - if ($scorm->scormtype != SCORM_TYPE_LOCAL && $scorm->updatefreq == SCORM_UPDATE_EVERYTIME) { + if ($scorm->updatefreq == SCORM_UPDATE_EVERYTIME) { scorm_parse($scorm, false); } $scoes = $DB->get_records_select('scorm_scoes', 'scorm = ? AND '.
              Hide
              danmarsden Dan Marsden added a comment -

              Thanks Matteo - good point, I've made that change too.

              Show
              danmarsden Dan Marsden added a comment - Thanks Matteo - good point, I've made that change too.
              Hide
              danmarsden Dan Marsden added a comment -

              this seems to work for me - I'm pretty sure we don't need to make the change to repository_filesystem::sync_reference as we don't need the files to sit in the actual file pool as they get loaded directly from the repo as linked files.

              Show
              danmarsden Dan Marsden added a comment - this seems to work for me - I'm pretty sure we don't need to make the change to repository_filesystem::sync_reference as we don't need the files to sit in the actual file pool as they get loaded directly from the repo as linked files.
              Hide
              cibot CiBoT added a comment -

              Fails against automated checks.

              Checked MDL-44548 using repository: https://github.com/danmarsden/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Fails against automated checks. Checked MDL-44548 using repository: https://github.com/danmarsden/moodle.git MOODLE_26_STABLE (branch: m26_MDL-44548 | CI Job ) MOODLE_27_STABLE (branch: m27_MDL-44548 | CI Job ) master (branch: master_MDL-44548 | CI Job ) Testing instructions are missing. More information about this report
              Hide
              damyon Damyon Wiese added a comment -

              Thanks Dan, the changes look good to me.

              [Y] Syntax
              [Y] Whitespace
              [-] Output
              [-] Language
              [-] Databases
              [Y] Testing (instructions and automated tests)
              [-] Security
              [-] Documentation
              [Y] Git
              [-] Third party code
              [Y] Sanity check

              All go for integration.

              Show
              damyon Damyon Wiese added a comment - Thanks Dan, the changes look good to me. [Y] Syntax [Y] Whitespace [-] Output [-] Language [-] Databases [Y] Testing (instructions and automated tests) [-] Security [-] Documentation [Y] Git [-] Third party code [Y] Sanity check All go for integration.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              cibot CiBoT added a comment -

              Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

              Show
              cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
              Hide
              marina Marina Glancy added a comment -

              Dan, thanks a lot for working on it.
              I feel that call to repository::sync_external_file() should be part of stored_file::import_external_file_contents() and this is a bug in files API. What do you think about it?

              Nobody uses function stored_file::import_external_file_contents() except for scorm that's why it was not noticed yet.

              Show
              marina Marina Glancy added a comment - Dan, thanks a lot for working on it. I feel that call to repository::sync_external_file() should be part of stored_ file::import_external_file_contents( ) and this is a bug in files API. What do you think about it? Nobody uses function stored_ file::import_external_file_contents( ) except for scorm that's why it was not noticed yet.
              Hide
              danmarsden Dan Marsden added a comment -

              thanks Marina - I've just moved this into repository::import_external_file_contents because I think it makes more sense in there, but the dropbox code also uses this function so it may cause unintended consequences - feel free to reject this and bounce back if think dropbox will be an issue.

              Show
              danmarsden Dan Marsden added a comment - thanks Marina - I've just moved this into repository::import_external_file_contents because I think it makes more sense in there, but the dropbox code also uses this function so it may cause unintended consequences - feel free to reject this and bounce back if think dropbox will be an issue.
              Hide
              marina Marina Glancy added a comment -

              Hi Dan, I just took a fresh look at the code. Sorry I did not realise it yesterday.

              The second next line after your change in repository/lib.php calls $file->get_contenthash(), this will automatically call sync. So basically your change in repository/lib.php does not make any difference. This is odd because it looks like a centrepoint of the patch. Please ping me when you come online on jabber

              Show
              marina Marina Glancy added a comment - Hi Dan, I just took a fresh look at the code. Sorry I did not realise it yesterday. The second next line after your change in repository/lib.php calls $file->get_contenthash() , this will automatically call sync. So basically your change in repository/lib.php does not make any difference. This is odd because it looks like a centrepoint of the patch. Please ping me when you come online on jabber
              Hide
              danmarsden Dan Marsden added a comment -

              hmm - reject this please - I must have something wrong here. - I'll take a look again later this week. Thanks.

              Show
              danmarsden Dan Marsden added a comment - hmm - reject this please - I must have something wrong here. - I'll take a look again later this week. Thanks.
              Hide
              marina Marina Glancy added a comment -

              sadly rejecting...

              Show
              marina Marina Glancy added a comment - sadly rejecting...
              Hide
              cibot CiBoT added a comment -

              Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

              Show
              cibot CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
              Hide
              myrandr Chris Lambert added a comment - - edited

              Has anyone tried Andre's solution on version 2.7.2? It was working for me under the previous version of 2.7 but we just pushed the upgrade to 2.7.2.

              Update: I tested this on 2.7.2 and works fine.

              Show
              myrandr Chris Lambert added a comment - - edited Has anyone tried Andre's solution on version 2.7.2? It was working for me under the previous version of 2.7 but we just pushed the upgrade to 2.7.2. Update: I tested this on 2.7.2 and works fine.
              Hide
              danmarsden Dan Marsden added a comment -

              here's another attempt at it. seems to work ok for me and we didn't need to change anything in the repo libs - must have been getting confused! Thanks!

              Show
              danmarsden Dan Marsden added a comment - here's another attempt at it. seems to work ok for me and we didn't need to change anything in the repo libs - must have been getting confused! Thanks!
              Hide
              poltawski Dan Poltawski added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              marina Marina Glancy added a comment -

              I set myself as a peer reviewer because I was looking at already. This looks like a much better approach. Thanks Dan!

              Show
              marina Marina Glancy added a comment - I set myself as a peer reviewer because I was looking at already. This looks like a much better approach. Thanks Dan!
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks Dan, integrated to master 27 and 26

              Show
              poltawski Dan Poltawski added a comment - Thanks Dan, integrated to master 27 and 26
              Hide
              fred Frédéric Massart added a comment -

              Sorry, failing this. It does not work on master and I have not tried other branches. Luckily Marina Glancy already knows why.

              Show
              fred Frédéric Massart added a comment - Sorry, failing this. It does not work on master and I have not tried other branches. Luckily Marina Glancy already knows why.
              Hide
              marina Marina Glancy added a comment -

              Dan Marsden I'm sorry for all your troubles with this issue. It is indeed bug in repository, I created MDL-47729 for it. Maybe it will fix your scorm bug too

              Show
              marina Marina Glancy added a comment - Dan Marsden I'm sorry for all your troubles with this issue. It is indeed bug in repository, I created MDL-47729 for it. Maybe it will fix your scorm bug too
              Hide
              poltawski Dan Poltawski added a comment -

              Reverted as requested by Marina, eagerly awaiting the anlysis

              Show
              poltawski Dan Poltawski added a comment - Reverted as requested by Marina, eagerly awaiting the anlysis
              Hide
              cibot CiBoT added a comment -

              Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

              Show
              cibot CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
              Hide
              danmarsden Dan Marsden added a comment -

              Thanks Marina/Fred - we might need to make the changes suggested here as well after that change has landed! - thanks for the work looking at it!

              Show
              danmarsden Dan Marsden added a comment - Thanks Marina/Fred - we might need to make the changes suggested here as well after that change has landed! - thanks for the work looking at it!
              Hide
              marina Marina Glancy added a comment -

              Hi Dan, I submitted MDL-47729 for peer review. I tried to cherry-pick your commit https://github.com/moodle/moodle/commit/2d9a4a5f93169207a166d6d7a7426652e2bf83a1 on top of my branch and it seems to work ok. So maybe you want to resubmit your issue for integration making MDL-47729 as a blocker

              Show
              marina Marina Glancy added a comment - Hi Dan, I submitted MDL-47729 for peer review. I tried to cherry-pick your commit https://github.com/moodle/moodle/commit/2d9a4a5f93169207a166d6d7a7426652e2bf83a1 on top of my branch and it seems to work ok. So maybe you want to resubmit your issue for integration making MDL-47729 as a blocker
              Hide
              renovator Paul Wakelam added a comment -

              Hi,
              This looks tricky
              If all goes well, on which version is this likely possibly to be released?
              I am a bit confused on this issue as it has been reopened and shows a fixed version of 2.7.4

              regards Paul

              Show
              renovator Paul Wakelam added a comment - Hi, This looks tricky If all goes well, on which version is this likely possibly to be released? I am a bit confused on this issue as it has been reopened and shows a fixed version of 2.7.4 regards Paul
              Hide
              danmarsden Dan Marsden added a comment -

              Paul - all going well this should get fixed in the next couple of weeks.

              Show
              danmarsden Dan Marsden added a comment - Paul - all going well this should get fixed in the next couple of weeks.
              Hide
              renovator Paul Wakelam added a comment -

              Dan - excellent

              Show
              renovator Paul Wakelam added a comment - Dan - excellent
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              cibot CiBoT added a comment -

              Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

              Show
              cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
              Hide
              poltawski Dan Poltawski added a comment -

              This is blocked by MDL-47729 (waiting for peer review)

              Show
              poltawski Dan Poltawski added a comment - This is blocked by MDL-47729 (waiting for peer review)
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Moving this out from current integration cycle because of dependency with MDL-47729.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Moving this out from current integration cycle because of dependency with MDL-47729 .
              Hide
              poltawski Dan Poltawski added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
              TIA and ciao

              Show
              poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              poltawski Dan Poltawski added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
              TIA and ciao

              Show
              poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              cibot CiBoT added a comment -

              Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

              Show
              cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
              Hide
              cibot CiBoT added a comment -

              Code verified against automated checks.

              Checked MDL-44548 using repository: https://github.com/danmarsden/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Code verified against automated checks. Checked MDL-44548 using repository: https://github.com/danmarsden/moodle.git MOODLE_27_STABLE (0 errors / 0 warnings) [branch: m27_MDL-44548 | CI Job ] MOODLE_28_STABLE (0 errors / 0 warnings) [branch: m28_MDL-44548 | CI Job ] master (0 errors / 0 warnings) [branch: master_MDL-44548 | CI Job ] More information about this report
              Hide
              poltawski Dan Poltawski added a comment -

              Still blocked

              Show
              poltawski Dan Poltawski added a comment - Still blocked
              Hide
              poltawski Dan Poltawski added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
              TIA and ciao

              Show
              poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              cibot CiBoT added a comment -

              Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

              Show
              cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
              Hide
              cibot CiBoT added a comment -

              Code verified against automated checks.

              Checked MDL-44548 using repository: https://github.com/danmarsden/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Code verified against automated checks. Checked MDL-44548 using repository: https://github.com/danmarsden/moodle.git MOODLE_27_STABLE (0 errors / 0 warnings) [branch: m27_MDL-44548 | CI Job ] MOODLE_28_STABLE (0 errors / 0 warnings) [branch: m28_MDL-44548 | CI Job ] master (0 errors / 0 warnings) [branch: master_MDL-44548 | CI Job ] More information about this report
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Still blocked...

              Show
              dobedobedoh Andrew Nicols added a comment - Still blocked...
              Hide
              poltawski Dan Poltawski added a comment -

              Hi Dan,

              I'm reopening this for now just to stop it continually being hit as a blocker, i'm going to comment on the otehr issue to request they send this issue at the same time as the blocker is resolved.

              Show
              poltawski Dan Poltawski added a comment - Hi Dan, I'm reopening this for now just to stop it continually being hit as a blocker, i'm going to comment on the otehr issue to request they send this issue at the same time as the blocker is resolved.
              Hide
              cibot CiBoT added a comment -

              Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

              Show
              cibot CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
              Hide
              marina Marina Glancy added a comment -

              Submitting for integration because the blocker is submitted

              Show
              marina Marina Glancy added a comment - Submitting for integration because the blocker is submitted
              Hide
              dmonllao David Monllaó added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
              TIA and ciao

              Show
              dmonllao David Monllaó added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              cibot CiBoT added a comment -

              Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

              Show
              cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
              Hide
              cibot CiBoT added a comment -

              Fails against automated checks.

              Checked MDL-44548 using repository: https://github.com/danmarsden/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Fails against automated checks. Checked MDL-44548 using repository: https://github.com/danmarsden/moodle.git MOODLE_27_STABLE [branch: m27_MDL-44548 | CI Job ] Info: the branch is based off moodle.git Info: base commit c228f82bbbdb69c05d6f3cf55d7a762b66b66016 being used as initial commit. Error: The m27_ MDL-44548 branch at https://github.com/danmarsden/moodle.git is very old (>60 days ago). Please rebase against current MOODLE_27_STABLE. MOODLE_28_STABLE [branch: m28_MDL-44548 | CI Job ] Info: the branch is based off moodle.git Info: base commit 79dfb7382447af4d38930c4d80c683cb4e28cdac being used as initial commit. Error: The m28_ MDL-44548 branch at https://github.com/danmarsden/moodle.git is very old (>60 days ago). Please rebase against current MOODLE_28_STABLE. master [branch: master_MDL-44548 | CI Job ] Info: the branch is based off moodle.git Info: base commit 06122e46fd16891787a08e9e3125465bea83eaf5 being used as initial commit. Error: The master_ MDL-44548 branch at https://github.com/danmarsden/moodle.git is very old (>60 days ago). Please rebase against current master. More information about this report
              Hide
              cibot CiBoT added a comment -

              Code verified against automated checks.

              Checked MDL-44548 using repository: https://github.com/danmarsden/moodle.git

              More information about this report

              Show
              cibot CiBoT added a comment - Code verified against automated checks. Checked MDL-44548 using repository: https://github.com/danmarsden/moodle.git MOODLE_27_STABLE (0 errors / 0 warnings) [branch: m27_MDL-44548 | CI Job ] MOODLE_28_STABLE (0 errors / 0 warnings) [branch: m28_MDL-44548 | CI Job ] master (0 errors / 0 warnings) [branch: master_MDL-44548 | CI Job ] More information about this report
              Hide
              dmonllao David Monllaó added a comment -

              Thanks Dan, integrated to master, 28 and 27.

              Show
              dmonllao David Monllaó added a comment - Thanks Dan, integrated to master, 28 and 27.
              Hide
              lameze Simey Lameze added a comment -

              Thanks for work on this Dan, I've followed the testing instructions on the link and works as described. Passing

              Show
              lameze Simey Lameze added a comment - Thanks for work on this Dan, I've followed the testing instructions on the link and works as described. Passing
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Closing this as fixed. Many, many thanks for your contribution!

              Being a great father is like shaving.
              No matter how good you shaved today,
              you have to do it again tomorrow.
              – Reed Markham

              (especially for all those fathers around celebrating today their day. every body else, apply the quote to another aspects of your life, lol)

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Closing this as fixed. Many, many thanks for your contribution! Being a great father is like shaving. No matter how good you shaved today, you have to do it again tomorrow. – Reed Markham (especially for all those fathers around celebrating today their day. every body else, apply the quote to another aspects of your life, lol)

                People

                • Votes:
                  11 Vote for this issue
                  Watchers:
                  22 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/May/15